partition mounting

Devils-Hawk <[email protected]> Mon, 11 Sep 2006 20:38:54 +0200
Newsgroups gmane.linux.gentoo.installer
Message-ID <[email protected]>
This is a multi-part message in MIME format.
--------------010606010902050303070508
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

There are IMHO currently 2 small problems with the way the partition
mounting is handled:

1.) It is not possible to mount a partition the installer recognizes as
unknown because it tries to call "mount -t unknown" which of course will
always fail. The attached fix does not really break something because if
mount recognizes the partition type it will succeed if it doesn't well
it will fail the same way it did before.

2.) It is possible to define Other partition types in the ncurses based
version and safe it to an installprofile.xml but it is not possible to
load such a profile because the self defined type is not a known type,
which results in the installer deleting the partition regardless of the
format or resize flags.


--------------010606010902050303070508
Content-Type: text/plain;
 name="unknown_partition.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="unknown_partition.patch"

diff -r -puN installer/src/GLIArchitectureTemplate.py installer_bkup/src/GLIArchitectureTemplate.py
--- installer/src/GLIArchitectureTemplate.py	2006-09-11 18:57:26.000000000 +0200
+++ installer_bkup/src/GLIArchitectureTemplate.py	2006-09-11 16:09:11.000000000 +0200
@@ -407,8 +407,6 @@ class ArchitectureTemplate:
 					if partition_type:
 						if partition_type == "fat32" or partition_type == "fat16": partition_type = "vfat"
 						partition_type = "-t " + partition_type + " "
-						if partition_type == "-t unknown ": partition_type = ""
-
 					parts_to_mount[mountpoint] = (mountopts, partition_type, tmp_partitions[partition]['devnode'])
 					
 				if partition_type == "linux-swap":


--------------010606010902050303070508--
-- 
[email protected] mailing list