Re: [RFC] support for optional dependencies in package.env

Vlastimil Babka kirjoitti:
> https://bugs.gentoo.org/show_bug.cgi?id=176182
> 
> Useful for jdbc providers (or my bsf attempt) etc. Package doesn't
> depend (in ebuild DEPEND nor RDEPEND nor PDEPEND) on another but can use
> if it it's on classpath. So we add new
> java-pkg_register-optional-dependency to eclass, which will record given
> package to OPTIONAL_DEPEND in package.env. gjl will process it if it's
> installed, and ignore if not (no errors about missing package).
> 

+# Will be put on classpath by launcher if they are installed. Typical
case are
+# JDBC implementations for various databases.

s/case are/case is/

+# Example: Record the optional dependency on whole xerces-2 and xalan,
+#	java-pkg_register-optional-dependency xerces-2,xalan
+# Example: Record the dependency on ant.jar from ant-core
+#	java-pkg_register-optional-dependency ant-core ant.jar

Maybe use packages that this was more likely to be used on.

+java-pkg_record-optional-jar_() {

copy of the code in the existing record-jar_ isn't it?

+    def opt_deps(self):

copy of the the deps function

Probably better to call a common function with some parameter in both cases.

Regards,
Petteri


-- 
[email protected] mailing list