Re: javatoolkit: new project layout

On 06-01-2008 10:29:29 +1300, Alistair Bush wrote:
[snip prefix cooperation question]
> I believe (and hope) that the distutils src_install() will handle this.
>  Basically setup.py has a --root="${D}" option
> 
> as in here
> 
> distutils_src_install() {
[snip]
> }
> 
> Is this acceptable?

Yes pretty much.

The distutils.eclass has already been ported to prefix, and works as far
as I'm aware.  That said, if it goes through the eclass, the
installation aspect would be fine.  Thanks a lot for that!

I see you already use /usr/bin/env python in all the python files that I
quickly checked, so that looks very promissing!

About this line:
  sys.path.insert(0, "/usr/share/javatoolkit/pym")
(found in buildparser, but I believe it's in more files)

would it be possible to do it like we do it in Portage?

 sys.path.insert(0, os.path.join(os.path.dirname(os.path.dirname(os.path.  realpath(__file__))), "pym"))

that would do the "magic" for prefix as well as that it makes
development for you a bit easier maybe.

The globs in findclass I guess we'll have to patch in the prefix case,
though I'm wondering if that doesn't need ROOT support anyway?
If you'd really want to make be happy you'd do a
  try:
    from portage.const import EPREFIX
  catch ImportError:
    EPREFIX = ''

  pkg = glob.glob(EPREFIX + '/usr/share/*/package.env')


-- 
Fabian Groffen
Gentoo on a different level
-- 
[email protected] mailing list