Re: Code review and main tree inclusion for java-mvn-src.eclass and java-pkg-simple.eclass

Christian Faulhammer <[email protected]> Thu, 10 Dec 2009 14:28:02 +0100
Newsgroups gmane.linux.gentoo.devel,gmane.linux.gentoo.java
Organization Gentoo
Message-ID <[email protected]>
--Sig_/mQF.gKR6EzU8jYAakxjj60Q
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi,

Martin von Gagern <[email protected]>:

> Christian Faulhammer wrote:
> > java-pkg-simple:
> > In my eyes, defining all local variables at the beginning of a
> > function makes it easier to read.
>=20
> Sorry, Fauli, i totally missed your mail as it was only addressed to
> gentoo-dev, while I've been intently watching gentoo-java...

 I am not subscribed to that list, so my mail would not get through.

> To sum things up: yes, I could change the local declarations, but I'd
> rather keep things as they are, unless you object more vehemently.

 No problem, it was a matter of style.

V-Li

--=20
Christian Faulhammer, Gentoo Lisp project
<URL:http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode

<URL:http://gentoo.faulhammer.org/>

--Sig_/mQF.gKR6EzU8jYAakxjj60Q
Content-Type: application/pgp-signature; name=signature.asc
Content-Disposition: attachment; filename=signature.asc

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.11 (GNU/Linux)

iEYEARECAAYFAksg92IACgkQNQqtfCuFneOfnQCfd8nplJ9VnbybZ0K9w/H+iac5
XJEAnRVvEUVGC1SKf4t4l6sFCdsKR7mw
=pIQq
-----END PGP SIGNATURE-----

--Sig_/mQF.gKR6EzU8jYAakxjj60Q--