Re: [PATCH] ant-tasks.eclass: use eapi7-ver
Duncan <[email protected]> Tue, 22 May 2018 07:56:51 +0000 (UTC)
| Newsgroups | gmane.linux.gentoo.devel,gmane.linux.gentoo.java |
|---|---|
| Message-ID | <[email protected]> |
Marty E. Plummer posted on Mon, 21 May 2018 23:01:10 -0500 as excerpted:
>> > +[[ ${EAPI} == 7 ]] || inherit eapi7-ver
>>
>> Always check for old EAPIs, instead of expecting people to keep
>> updating this forever.
>>
> Would you prefer something like [[ ${EAPI} ~= [0-6] ]] && inherit
> eapi7-ver, then?
> The way I see it, every consumer of ant-tasks is eapi 5 right now, 5 and
> 6 if my pull request is accepted. Once every consumer is eapi 7 or
> greater,
> this line can be removed entirely and it won't be needing updates
> 'forever'.
Test defensively. We're not just talking EAPI=8, etc, here. What
happens if someone typos EAPI=56 or some such? Positively support what
you recognize. If it's unrecognized, it should always fall thru to an
error saying it's unsupported. Much easier to debug that way. =:^)
--
Duncan - List replies preferred. No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master." Richard Stallman