Re: [PATCH 0/2] Use consistent list of booleans & validate verify-commit-signature

On 7/2/20 8:50 AM, Wynn Wolf Arbor wrote:
> Hi,
> 
> Whilst configuring a bunch of overlay repositories via repos.conf, I
> discovered that not all boolean options take the same values. Some only
> take 'true' and 'false', others are documented only as 'yes' or 'no',
> but take 'true', 'false', 'yes', and 'no'. This is inconsistent and can
> lead to very confusing outcomes, so I decided to write a patch.
> 
> I came across https://bugs.gentoo.org/703698 whilst working on this, and
> since my work was tangentially related, decided to fix that as well.
> 
> Wynn Wolf Arbor (2):
>       repos.conf: Use consistent list of values for boolean options
>       git: Verify boolean values passed to sync-git-verify-commit-signature
> 
>  lib/portage/repository/config.py         |  4 +--
>  lib/portage/sync/modules/git/__init__.py | 11 ++++++++
>  lib/portage/sync/modules/git/git.py      |  2 +-
>  lib/portage/sync/modules/rsync/rsync.py  |  2 +-
>  man/portage.5                            | 45 +++++++++++++++-----------------
>  5 files changed, 36 insertions(+), 28 deletions(-)


Thanks! I've merged both patches, with a couple of additional lower()
calls for case insensitivity:

https://gitweb.gentoo.org/proj/portage.git/commit/?id=141ef203661248a2c29945f8c6770ce0c242eaf0
https://gitweb.gentoo.org/proj/portage.git/commit/?id=33b08baff4825bf84f639cf213de92ed36f76771
-- 
Thanks,
Zac

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQKTBAEBCgB9FiEE8OgXaltWzqgSupCu0HX7jBBKPSAFAl7+XPxfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEYw
RTgxNzZBNUI1NkNFQTgxMkJBOTBBRUQwNzVGQjhDMTA0QTNEMjAACgkQ0HX7jBBK
PSCC/A//ekBTeEJcPCgwnl9ATX3qQSZKo/G+DRZYpouNGUhK9Yi6LR5boDI9tskm
ZDyXNqaDRum9OlRkNARCLW7Q2HvWs3pE4xvyPEIAYwp1FMbLR9ZNKNXkko1XXySg
5Qgb0el1f0HRIrbsXQ/s0tve8aTbCUvhcUXzmpTby1Kghsc0x3ScESZ31sSC/35z
ZES/uDKu7KLv0jVheOho8lzc7hCSAxgV32Z1BJu8mwHM371bbWDzyFG5E81D1QYu
PVewmgzqUqWTZvpib/eXd4rIphzRk83clhrLHRCD1WU+NR9ZTU19nvEZCdhZ/sJL
A3PVr6fWur72nTkhy5Vsue5JOTUUjvk4e5+MfC9ODZapRHAz621gbLEp7ykE7Zz6
IYpusWF3V2GEC5Sl355kyzf4Q/zbNnmf7/sKNnJdhhxK0z4mc47FwOy/+kw6kcTv
e4w8FAsKcRcR7LrbrGnXRVeFuGSQ4gyf6928WEuQ64EdbAuk1R2IN6padtpAGzTv
+1WkHvHjgWDpyVffBfA7xUOg57BPslrBDkt0z/RL/0g1c8AS1Hb57xx+Dd3tt239
hXiGYnZilNP5bhzsgdQxO9enhsA8DYrQunYBUHmQQzyh8JfEHTF9g5A5694mSTdq
CsX1IiKKgbGTRRpREqy5qqDp1OS0XXsq1EcSANghMjF5Q8yElEI=
=dUxf
-----END PGP SIGNATURE-----