Re: [PATCH 1/3] Add caching to catpkgsplit function
Francesco Riosa <[email protected]>
| Newsgroups | gmane.linux.gentoo.portage.devel |
|---|---|
| Message-ID | <[email protected]> |
Il 06/07/20 17:50, Michael 'veremitz' Everitt ha scritto: > On 06/07/20 16:26, Francesco Riosa wrote: >> Il 29/06/20 03:58, Sid Spry ha scritto: >>> There are libraries that provide decorators, etc, for caching and >>> memoization. >>> Have you evaluated any of those? One is available in the standard library: >>> https://docs.python.org/dev/library/functools.html#functools.lru_cache >>> >>> I comment as this would increase code clarity. >>> >> I think portage developers try hard to avoid external dependancies >> I hope hard they do >> >> > I think the key word here is 'external' - anything which is part of the > python standard library is game for inclusion in portage, and has/does > provide much needed optimisation. Many of the issues in portage are > so-called "solved problems" in computing terms, and as such, we should take > advantage of these to improve performance at every available opportunity. > Of course, there are presently only one, two or three key developers able > to make/test these changes (indeed at scale) so progress is often slower > than desirable in current circumstances... > > [sent direct due to posting restrictions...] yes I've replied too fast and didn't notice Sid was referring to _standard_ libraries (not even recent additions) sorry for the noise - Francesco