Re: [PATCH] portage.output: Replace darkblue colors with teal

Fabian Groffen <[email protected]> Sat, 4 Dec 2021 09:56:09 +0100
Newsgroups	gmane.linux.gentoo.portage.devel
Organization	Gentoo Foundation, Inc.
Message-ID	<[email protected]>
Why don't you change your color.map instead of changing the default for
everyone?

Thanks,
Fabian

On 04-12-2021 05:48:49 +0100, Michał Górny wrote:
> The "darkblue" color is often barely visible on dark terminals which
> makes reading emerge output really hard (I basically have to copy-paste
> it a lot in order to be able to read it at all).  Replace it with teal
> that does not seem to have any significant use in the output.
> 
> Signed-off-by: Michał Górny <[email protected]>
> ---
>  lib/portage/output.py | 6 +++---
>  man/color.map.5       | 6 +++---
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> 
> The before-after screenshot can be found on the PR:
> https://github.com/gentoo/portage/pull/776
> 
> 
> diff --git a/lib/portage/output.py b/lib/portage/output.py
> index 42f487f8a..77375b012 100644
> --- a/lib/portage/output.py
> +++ b/lib/portage/output.py
> @@ -157,7 +157,7 @@ _styles["UNMERGE_WARN"] = ("red",)
>  _styles["SECURITY_WARN"] = ("red",)
>  _styles["MERGE_LIST_PROGRESS"] = ("yellow",)
>  _styles["PKG_BLOCKER"] = ("red",)
> -_styles["PKG_BLOCKER_SATISFIED"] = ("darkblue",)
> +_styles["PKG_BLOCKER_SATISFIED"] = ("teal",)
>  _styles["PKG_MERGE"] = ("darkgreen",)
>  _styles["PKG_MERGE_SYSTEM"] = ("darkgreen",)
>  _styles["PKG_MERGE_WORLD"] = ("green",)
> @@ -165,8 +165,8 @@ _styles["PKG_BINARY_MERGE"] = ("purple",)
>  _styles["PKG_BINARY_MERGE_SYSTEM"] = ("purple",)
>  _styles["PKG_BINARY_MERGE_WORLD"] = ("fuchsia",)
>  _styles["PKG_UNINSTALL"] = ("red",)
> -_styles["PKG_NOMERGE"] = ("darkblue",)
> -_styles["PKG_NOMERGE_SYSTEM"] = ("darkblue",)
> +_styles["PKG_NOMERGE"] = ("teal",)
> +_styles["PKG_NOMERGE_SYSTEM"] = ("teal",)
>  _styles["PKG_NOMERGE_WORLD"] = ("blue",)
>  _styles["PROMPT_CHOICE_DEFAULT"] = ("green",)
>  _styles["PROMPT_CHOICE_OTHER"] = ("red",)
> diff --git a/man/color.map.5 b/man/color.map.5
> index 288bf7fbd..92a1baa91 100644
> --- a/man/color.map.5
> +++ b/man/color.map.5
> @@ -40,7 +40,7 @@ Defines color used for numbers indicating merge progress.
>  \fBPKG_BLOCKER\fR = \fI"red"\fR
>  Defines color used for unsatisfied blockers.
>  .TP
> -\fBPKG_BLOCKER_SATISFIED\fR = \fI"darkblue"\fR
> +\fBPKG_BLOCKER_SATISFIED\fR = \fI"teal"\fR
>  Defines color used for satisfied blockers.
>  .TP
>  \fBPKG_MERGE\fR = \fI"darkgreen"\fR
> @@ -63,10 +63,10 @@ package.
>  Defines color used for world packages planned to be merged using a binary
>  package.
>  .TP
> -\fBPKG_NOMERGE\fR = \fI"darkblue"\fR
> +\fBPKG_NOMERGE\fR = \fI"teal"\fR
>  Defines color used for packages not planned to be merged.
>  .TP
> -\fBPKG_NOMERGE_SYSTEM\fR = \fI"darkblue"\fR
> +\fBPKG_NOMERGE_SYSTEM\fR = \fI"teal"\fR
>  Defines color used for system packages not planned to be merged.
>  .TP
>  \fBPKG_NOMERGE_WORLD\fR = \fI"blue"\fR
> -- 
> 2.34.1
> 
> 

-- 
Fabian Groffen
Gentoo on a different level
signature.asc (application/pgp-signature, 488 B)