Re: [PATCH] emake: explicitly set SHELL

Mike Gilbert <[email protected]> Mon, 25 Jul 2022 19:38:11 -0400
Newsgroups gmane.linux.gentoo.portage.devel
Message-ID <CAJ0EP41FNtxef4cGUcpLpagdOEPkJ9K5t4hQLdHggXCTjzpnRg@mail.gmail.com>
On Mon, Jul 25, 2022 at 11:28 AM Fabian Groffen <[email protected]> wrote:
>
> bin/ebuild-helpers/emake: force SHELL to be set
>
> On Prefix systems /bin/sh can be anything, including very ancient.  So
> ensure we're running with bash, since that's what Gentoo Linux is
> expecting /bin/sh to be (by default, at least).
>
> Provide a fallback for the (near impossible) case that we use a bash
> that doesn't set BASH, or when we don't use bash at all.  This is not
> expected, though, as we explicitly require bash throughout all Portage,
> so we don't really care about using a non-Prefixed one, for this really
> shouldn't happen.

I'm a little on the fence about this: in theory, Makefiles should use
POSIX-compatible shell commands unless the author explicitly chooses
to use bash.

I guess we can get away with this since ebuilds always require bash anyway.