Re: [PATCH] 80libraries: add support for Darwin targets

--Apple-Mail=_DF981453-6A32-4F78-8B85-6CB1AF637344
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii



> On 26 Jul 2022, at 00:33, Mike Gilbert <[email protected]> wrote:
>=20
> On Mon, Jul 25, 2022 at 11:38 AM Fabian Groffen <[email protected]> =
wrote:
>>=20
>> bin/install-qa-check.d/80libraries: support Darwin/Mach-O objects
>>=20
>> Check for dylib on Darwin, so on everything else.
>>=20
>> Signed-off-by: Fabian Groffen <[email protected]>
>>=20
>> diff --git a/bin/install-qa-check.d/80libraries =
b/bin/install-qa-check.d/80libraries
>> index 8dc35bb87..a477ec9cb 100644
>> --- a/bin/install-qa-check.d/80libraries
>> +++ b/bin/install-qa-check.d/80libraries
>> @@ -140,7 +140,9 @@ lib_check() {
>>        local abort=3D"no"
>>        local a s
>>        for a in "${ED%/}"/usr/lib*/*.a ; do
>> -               s=3D${a%.a}.so
>> +               [[ ${CHOST} =3D=3D *-darwin* ]] \
>> +                       && s=3D${a%.a}.dylib \
>> +                       || s=3D${a%.a}.so
>=20
> I would find this much easier to read if you converted it to an
> if/else statement instead of chaining && and ||.

Yes, please.

--Apple-Mail=_DF981453-6A32-4F78-8B85-6CB1AF637344
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iNUEARYKAH0WIQQlpruI3Zt2TGtVQcJzhAn1IN+RkAUCYt9ZEl8UgAAAAAAuAChp
c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0MjVB
NkJCODhERDlCNzY0QzZCNTU0MUMyNzM4NDA5RjUyMERGOTE5MAAKCRBzhAn1IN+R
kNlUAQDknKAOmmMbX0RMxmvOU/+r0cja6EvpXn1py34qyUCy6wEAsl7V/WNhWk/y
Tq15WB3VN13aZ1W34PLGPxiUyFfjTgg=
=40Dh
-----END PGP SIGNATURE-----

--Apple-Mail=_DF981453-6A32-4F78-8B85-6CB1AF637344--