Re: [PATCH 2/2] Add caching to _slot_operator_check_reverse_dependencies

Zac Medico <[email protected]> Mon, 28 Nov 2022 07:47:25 -0800
Newsgroups gmane.linux.gentoo.portage.devel
Message-ID <[email protected]>
On 11/24/22 19:36, Pin-yen Lin wrote:
> Add lru_cache to speed up the running time of "Calculating
> dependencies".
> 
> In a ChromeOS use case, this patch decreases the running time from
> 311s to 197s with almost no memory usage increase.
> 
> Signed-off-by: Pin-yen Lin <[email protected]>
> ---
>   lib/_emerge/depgraph.py | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/lib/_emerge/depgraph.py b/lib/_emerge/depgraph.py
> index ce6cabcc1..9649bb2a8 100644
> --- a/lib/_emerge/depgraph.py
> +++ b/lib/_emerge/depgraph.py
> @@ -2240,6 +2240,7 @@ class depgraph:
>   
>           return None
>   
> +    @functools.lru_cache(maxsize=100)
>       def _slot_operator_check_reverse_dependencies(
>           self, existing_pkg, candidate_pkg, replacement_parent=None
>       ):

Merged. Thank you!

https://gitweb.gentoo.org/proj/portage.git/commit/?id=0c42cc962e1926ecbdc83d903a2804f9e037f2a9
https://gitweb.gentoo.org/proj/portage.git/commit/?id=839ab46be1777e5886da28b98b53a462b992c5bf
-- 
Thanks,
Zac