Re: [PATCH] Stop implicitly manipulating `NO_COLOR`/`NOCOLOR`

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

>>>>> On Sun, 26 Nov 2023, Micha=C5=82 G=C3=B3rny wrote:

> 3. Forcing `NO_COLOR=3D1` turns out to cause random test failures,
>    and while fixing them is commendable, it is a pain for arch testing
>    and it is currently blocking stabilization requests.

I'd argue that test suites that fail because of NO_COLOR are broken.
IIUC, these failures will show up for users who set NO_COLOR=3D1 in their
make.conf or in the environment?

> With the new approach, the color output in programs is consistent
> between using ``--jobs`` or ``--quiet-build``, and not.  Therefore,
> both cases generate uniform logs.  In order to obtain logs free of color
> codes, one can either filter them via `ansifilter(1)` (as the manpages
> already recommend) or explicitly set `NO_COLOR`.

Will this still guarantee that NO_COLOR=3D1 from the environment is always
passed on to the build system?

Otherwise, it would break ebuild-mode in some configurations.

Ulrich

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQFDBAEBCAAtFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmVjgW4PHHVsbUBnZW50
b28ub3JnAAoJEFGIM1CIQV4uVyIIAKSaKCHheWuwSJPXt/kaWgbKqwg8S7VNm0X9
/nsZaI2xnZ2lf8YJqnAIE/Kg3LMdWN8JRNCQZ0vB2fGZrbeCWVS9rVYFL0kA6cAl
H76zhBygBeStJ8N6f15oesaVTMBh6AuZZB+g+kGsUDXbFi40xWfqXKCeWzVg23Jv
+V+JQWL6trRwIfUcwukgwpY2PO/lik5vEdMY+soiv5t7YwYTOX5nKyuL73rh4+jt
40bxGQrEKh29U4m6KTHkzA/nCwtDKxrTw4SV76MYrVUmRwyUFjmfEEq8+SlHUolY
3TZkKG21lUlenEbsJyGb4A+9Ib1EOzjuatdmnW+LfvYu09MqT1U=
=/y8Q
-----END PGP SIGNATURE-----
--=-=-=--