Re: ni_usb: bug when setting kernel timer

On Mon, May 7, 2018 at 10:46 AM, Stefan Mahr <[email protected]> wrote:
> Hi,
>
> There's a timer initialisation bug in ni_usb driver, especially
> for NI_USB_B. The timer is setup after first use of mod_timer
> (ni_usb_b_read_serial_number->usb_send_bulk_msg), so kernel throws a
> bug in timer.c: BUG_ON(!timer->function);
>
> Attached patch should fix this issue.
>

Thanks, I'm going to try implementing timer_setup using setup_timer in
a compatibility header later today, to get rid of needing to #ifdef
every timer setup.  I'll incorporate your change into that.


-- 
Frank

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot