Re: patch proposal
Michael Schwingen <[email protected]> Sun, 28 Jul 2024 23:59:48 +0200
| Newsgroups | gmane.linux.hardware.gpib.general |
|---|---|
| Message-ID | <[email protected]> |
On 28.07.24 23:07, marcello.carla via Linux-gpib-general wrote: > > 2) > I see the problem of a buffer overflow while writing, but to reproduce > repeated interrupts with slow edges I had to use rising and falling times > longer than 100 us, a not common event, and only with RPi3b. RPi4 and > RPi5 have Schmitt triggers on input, and this makes the event impossible. > Yet, a good interlock between NDAC and NRFD interrupts is advisable, and > the current implementation (for historical reasons) is a mess. Sorry for > that and thanks again to Michael for signalling the problem. A revision > of this part of the code was already on schedule. Asap, as usual. What about my proposal of changing the interrupts to be level-triggered? I believe my code addresses these problems as well. Should I prepare a clean patch for review? cu Michael