Re: [Patch] Collection of patches for crmsh

On Mon, Jan 19, 2015 at 04:56:14PM +0300, Vladislav Bogdanov wrote:
> Hi Dejan,
> 
> 19.01.2015 16:30, Dejan Muhamedagic wrote:
> >Hi Vladislav,
> >
> >>[...]
> >>Fix transition start detection.
> >>
> >>--- a/modules/constants.py  2014-12-22 08:48:26.000000000 +0000
> >>+++ b/modules/constants.py  2014-12-22 13:07:43.945077805 +0000
> >>@@ -272,7 +272,7 @@
> >>  # r.group(3) file number
> >>  transition_patt = [
> >>      # transition start
> >>-    "crmd.* do_te_invoke: Processing graph ([0-9]+) .*derived from (.*/pe-[^-]+-(%%)[.]bz2)",
> >>+    "pengine.* process_pe_message: Calculated Transition ([0-9]+): (.*/pe-[^-]+-(%%)[.]bz2)",
> >
> >Do you know when this changed?
> 
> Original message (from do_te_invoke) was downgraded into the 'info'
> priority a long ago (probably during that Andrew's massive logging
> cleanup), while process_pe_message' one still remains at the
> 'notice' level. First my patch has 2012-12-26 as its date (for
> crmsh-1.2.4), so the change was done before that. iirc
> process_pe_message's message was always there, both messages were
> printed before that cleanup.

Ah, that rings the bell. But there's more than just that one:

https://build.opensuse.org/package/view_file/network:ha-clustering:Factory/pacemaker/bug-806256_pacemaker-log-level-notice.patch?expand=1

> >The reason I'm asking is that crmsh tries to support multiple
> >pacemaker versions, so I'm not sure if we can just replace this
> >pattern.
> >
> >>Make tar follow symlinks.
> >>
> >>--- a/modules/crm_pssh.py   2013-08-12 12:52:11.000000000 +0000
> >>+++ b/modules/crm_pssh.py   2013-08-12 12:53:32.666444069 +0000
> >>@@ -170,7 +170,7 @@
> >>          dir = "/%s" % r.group(1)
> >>          red_pe_l = [x.replace("%s/" % r.group(1), "") for x in pe_l]
> >>          common_debug("getting new PE inputs %s from %s" % (red_pe_l, node))
> >>-        cmdline = "tar -C %s -cf - %s" % (dir, ' '.join(red_pe_l))
> >>+        cmdline = "tar -C %s -chf - %s" % (dir, ' '.join(red_pe_l))
> >
> >Just curious: where did you find links in the PE input
> >directories?
> 
> Ahm, you know, systems are soooo different around a world ;)

True. And I _do_ appreciate that fact.

> And system administrators sometimes want to do weird things ;)

Which is their prerogative too.

> Actually that one is specific to my diskless clusters, but it wont
> hurt anyways.

Diskless? Cool.

Cheers,

Dejan

> >
> >And many thanks for the patches!
> >
> >Cheers,
> >
> >Dejan
> >>
> >>
> >>Best,
> >>Vladislav
> >>
> >>_______________________________________________
> >>Linux-HA mailing list
> >>[email protected]
> >>http://lists.linux-ha.org/mailman/listinfo/linux-ha
> >>See also: http://linux-ha.org/ReportingProblems
> >_______________________________________________
> >Linux-HA mailing list
> >[email protected]
> >http://lists.linux-ha.org/mailman/listinfo/linux-ha
> >See also: http://linux-ha.org/ReportingProblems
> >
> 
> _______________________________________________
> Linux-HA mailing list
> [email protected]
> http://lists.linux-ha.org/mailman/listinfo/linux-ha
> See also: http://linux-ha.org/ReportingProblems
_______________________________________________
Linux-HA mailing list
[email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha
See also: http://linux-ha.org/ReportingProblems