Re: [PATCH] uevent: send events in correct order according to seqnum (v2)

Kay Sievers <[email protected]>
Newsgroups gmane.linux.hotplug.devel,gmane.linux.kernel
Message-ID <CAPXgP13+Av39cFMxU1YNNPEc=yMjRV-pCXf-r_RHcNtDQ-xESw@mail.gmail.com>
On Wed, Mar 7, 2012 at 10:59, Andrew Vagin <[email protected]> wrote:
> The queue handling in the udev daemon assumes that the events are
> ordered.

> -       retval = add_uevent_var(env, "SEQNUM=%llu", (unsigned long long)seq);
> +       retval = add_uevent_var(env, "SEQNUM=%llu", (unsigned long long)++uevent_seqnum);
>        if (retval)
>                goto exit;

We need to unlock the mutex before the goto exit?

Other than that, looks good to me.

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.