Re: [RFC Patch V1 15/30] mm, igb: Use cpu_to_mem()/numa_mem_id() to support memoryless node
Nishanth Aravamudan <[email protected]> Mon, 21 Jul 2014 14:09:00 -0700
| Newsgroups | gmane.linux.kernel.mm,gmane.linux.hotplug.devel,gmane.linux.kernel,gmane.linux.drivers.e1000.devel,gmane.linux.network |
|---|---|
| Message-ID | <[email protected]> |
On 21.07.2014 [12:53:33 -0700], Alexander Duyck wrote: > I do agree the description should probably be changed. There shouldn't be > any panics involved, only a performance impact as it will be reallocating > always if it is on a node with no memory. Yep, thanks for the review. > My intention on this was to make certain that the memory used is from the > closest node possible. As such I believe this change likely honours that. Absolutely, just wanted to make it explicit that it's not a functional fix, just a performance fix (presuming this shows up at all on systems that have memoryless NUMA nodes). I'd suggest an update to the comments, as well. Thanks, Nish -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>