Re: [PATCH v3 8/9] pci: fix dyn_id add TOCTOU
[email protected] Tue, 07 Jul 2026 14:12:19 +0000
| Newsgroups | gmane.linux.scsi,gmane.linux.ide,gmane.comp.video.dri.devel,gmane.linux.kernel.pci |
|---|---|
| Message-ID | <[email protected]> |
> Currently there is a TOCTOU issue in new_id_store as the dyn ID insertion
> in pci_add_dynid and the pci_match_device are in separate critical
> sections.
>
> Fix this by moving the existing ID check to inside pci_add_dynid and only
> check against the static ID table outside the critical section.
>
> Fixes: 3853f9123c18 ("PCI: Avoid duplicate IDs in driver dynamic IDs list")
> Signed-off-by: Gary Guo <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=8