Re: [PATCH v2 0/7] pci: fix UAF and TOCTOU related to dynamic ID
Bjorn Helgaas <[email protected]> Tue, 21 Jul 2026 17:36:46 -0500
| Newsgroups | gmane.linux.kernel.pci,gmane.linux.kernel,gmane.linux.ide,gmane.linux.scsi,gmane.linux.kernel.ipack,gmane.linux.network |
|---|---|
| Message-ID | <20260721223646.GA695827@bhelgaas> |
On Tue, Jul 21, 2026 at 05:30:47PM -0500, Bjorn Helgaas wrote: > On Tue, Jun 30, 2026 at 12:09:00PM +0100, Gary Guo wrote: > > While working on improving the Rust abstractions [1], Sashiko reported that > > an existing UAF issue related to dynamic ID, which I find to be genuine. > > When taking a look at the code I also find a TOCTOU issue where the > > existence check of dynamic ID happens in a separate critical section as the > > actual insertion. This series fix both issues. > ... > Run "git log --oneline drivers/pci" and match style (capitalize "PCI:" > and first word of subject). > > At least in the PCI patch commit logs and comments, add "()" after > function names. > > s/id/ID/ throughout (it's currently inconsistent). > s/pci/PCI/ throughout (ditto) Oops, sorry, I meant to reply to v3, not v2.