Re: netfilter6: ICMPv6 type 143 doesn't match

Herbert Xu <[email protected]>
Newsgroups gmane.linux.network,gmane.comp.security.firewalls.netfilter.devel,gmane.linux.ipv6.usagi.users
Organization Core
Message-ID <[email protected]>
Patrick McHardy <[email protected]> wrote:
> 
> +static inline int mld_dev_queue_xmit2(struct sk_buff *skb)
> +{
> +       struct net_device *dev = skb->dev;
> +
> +       if (dev->hard_header) {
> +               unsigned char ha[MAX_ADDR_LEN];
> +               int err;
> +
> +               ndisc_mc_map(&skb->nh.ipv6h->daddr, ha, dev, 1);
> +               err = dev->hard_header(skb, dev, ETH_P_IPV6, ha, NULL, skb->len);
> +               if (err < 0) {
> +                       IP6_INC_STATS(IPSTATS_MIB_OUTDISCARDS);

You're now incrementing this twice since the callers will also
increment this.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.