Re: [3/3] gigaset: prune use of tty_buffer_request_room
Karsten Keil <[email protected]>
| Newsgroups | gmane.linux.kernel,gmane.linux.network,gmane.linux.isdn.i4l.user,gmane.linux.isdn.i4l.devel |
|---|---|
| Message-ID | <1268665009.25656@pingi> |
Calling tty_buffer_request_room() before tty_insert_flip_string() is unnecessary, costs CPU and for big buffers can mess up the multi-page allocation avoidance. Signed-off-by: Tilman Schmidt <[email protected]> Acked-by: Karsten Keil <[email protected]> --- Note to -stable: applies correctly to 2.6.33 with fuzz 2. drivers/isdn/gigaset/interface.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/isdn/gigaset/interface.c b/drivers/isdn/gigaset/interface.c index a1bcbc2..f0dc6c9 100644 --- a/drivers/isdn/gigaset/interface.c +++ b/drivers/isdn/gigaset/interface.c @@ -628,7 +628,6 @@ void gigaset_if_receive(struct cardstate *cs, if (tty == NULL) gig_dbg(DEBUG_IF, "receive on closed device"); else { - tty_buffer_request_room(tty, len); tty_insert_flip_string(tty, buffer, len); tty_flip_buffer_push(tty); }