Re: [PATCH 2/2] isdn: avoid calling tty_ldisc_flush() in atomic context
David Miller <[email protected]>
| Newsgroups | gmane.linux.network,gmane.linux.isdn.i4l.devel,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
From: Tilman Schmidt <[email protected]> Date: Tue, 6 Jul 2010 02:18:27 +0200 (CEST) > Remove the call to tty_ldisc_flush() from the RESULT_NO_CARRIER > branch of isdn_tty_modem_result(), as already proposed in commit > 00409bb045887ec5e7b9e351bc080c38ab6bfd33. > This avoids a "sleeping function called from invalid context" BUG > when the hardware driver calls the statcallb() callback with > command==ISDN_STAT_DHUP in atomic context, which in turn calls > isdn_tty_modem_result(RESULT_NO_CARRIER, ~), and from there, > tty_ldisc_flush() which may sleep. > > Impact: bugfix > Signed-off-by: Tilman Schmidt <[email protected]> Applied to net-next-2.6, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html