Re: [PATCH 0/8] Misc LCR build fixes / new installation directories

Jānis Rukšāns wrote:
> Hi,
>
> Here's a bunch of patches I'm using for building LCR RPMs for Fedora 17
> (originally Fedora 9 and 14, I'm slow when it comes to upgrading).
>   
hi janis,

thank you very much for your patches. i am happy to commit them.
> The first three are related to Asterisk and chan_lcr, fixing a couple of
> warnings during configure checks and compliation. M4 quoting is something
> I might never wrap my head around, but at least now there are no more
> 'trailing tokens' in includes.
>   
the first 4 patches are commited.
> Next four are needed for RPM build: fixes for distcheck to get a neat
> source tarball and support for configure'd installation directories. The
> only two files left with hardcoded paths (sans GSM) are options.conf and
> genrc.c. It turned out too tricky to generate options.conf from Makefile;
> as for genrc I did not bother to patch it because 1) I feel it belongs
> to mISDNuser if anything 2) it makes no sense if systemd is used 3) the
> same thing can be done with a configuration file in modprobe.d
>   
patches 5,6,7 are not yet commited, because it changes "hardcoded" path
"/usr/local/lcr" for installation of files. i would like to ask the
community first what they think about installing LCR files to these
locations:

--
make install
...
mkdir -p '/usr/local/etc/lcr'
mkdir -p '/usr/local/share/lcr'
mkdir -p '/usr/local/var/log/lcr'
mkdir -p '/usr/local/var/lib/lcr/extensions'
...
--

it really makes sense have this structured. in this case, if nobody
disagrees, i will commit the 3 remaining patches and change documentation.

> The last one is strictly necessary only if LCR is being run as non-root
> together with PIDFile systemd option.
>   
also commited.
> PS. If somebody is interested in the RPMs, let me know and I'll see if I
> can put them online somewhere.
>   
i think i need to update the linux-call-route.de page and put some
recent source + git info on it. i would like to do that as soon as all
patches are applied.

thanx again for your work and detailled descriptions of your patches.

best regards,

andreas
 
_______________________________________________
isdn4linux mailing list
[email protected]
https://www.isdn4linux.de/mailman/listinfo/isdn4linux