| Newsgroups |
gmane.linux.isdn.i4l.user |
| Message-ID |
<[email protected]> |
Hi,
is it possible to push the patch to git?
Best regards
Bodo
On 13.12.2013 10:09, Andreas Eversberg wrote:
> Bodo.Pfelzer-S0/[email protected] wrote:
>> Hi,
>>
>> I still get no audio from LCR to ISDN with my HFC-PCI card.
>>
>> I think the crucial code is located in line 790 of hfcpci.c. If
>> FLG_FILLEMPTY is set, no real data will ever be written to the card.
>> dsp_function enables that flag when receiving PH_ACTIVATE.
>>
>> What is the contract of FLG_FILLEMPTY. Should it emit silence, if no
>> data is available? Or should it emit silence forever, because that's
>> what it actually does.
>>
>> When I deactivate the if clause in line 790 I get audio output as desired.
>>
>> Bodo
>> _______________________________________________
>> isdn4linux mailing list
>> [email protected]
>> https://www.isdn4linux.de/mailman/listinfo/isdn4linux
>>
> hi bodo, hi kartsen,
>
> FLG_FILLEMPTY should only emit silence, if there is no data available.
> this is useful to maintain silence level after audio stream stops.
>
> my attached patch fixes this issue, at least for hfcpci.c. after quickly
> reviewing commit 2a81b2dc (FLG_FILLEMPTY support for card drivers), i
> only see this issue for hfcpci.c.
>
> best regards,
>
> andreas
>
>
>
>
>