Re: [PATCH v4 2/2] tracing: Remove trace_printk.h from kernel.h
Nathan Chancellor <[email protected]> Thu, 25 Jun 2026 16:41:58 -0700
| Newsgroups | gmane.comp.freedesktop.xorg.drivers.intel,gmane.linux.kernel,gmane.linux.documentation,gmane.linux.kbuild.devel,gmane.linux.ports.ppc64.devel,gmane.comp.video.dri.devel,gmane.linux.ports.arm.kernel,gmane.linux.drivers.rdma,gmane.linux.usb.general,gmane.comp.file-systems.ext4,gmane.linux.nfs,gmane.comp.emulators.kvm.devel |
|---|---|
| Message-ID | <20260625234158.GA261868@ax162> |
Hi Steve, On Thu, Jun 25, 2026 at 06:40:09AM -0400, Steven Rostedt wrote: > From: Steven Rostedt <[email protected]> > > There have been complaints about trace_printk.h causing more build time > for being in kernel.h if it changes. There is also an effort to clean up > kernel.h to have it not include unneeded header files. Move trace_printk.h > out of kernel.h and place it in the headers and C files that use it. > > Link: https://lore.kernel.org/all/CAHk-=wikCBeVFjVXiY4o-oepdbjAoir5+TcAgtL12c4u1TpZLQ@mail.gmail.com/ > > Suggested-by: Yury Norov <[email protected]> > Acked-by: Masami Hiramatsu (Google) <[email protected]> > Signed-off-by: Steven Rostedt <[email protected]> This patch breaks lib/test_context-analysis.c for me in several configurations: In file included from lib/test_context-analysis.c:9: In file included from include/linux/local_lock.h:5: include/linux/local_lock_internal.h:46:2: error: use of undeclared identifier '_THIS_IP_' 46 | lock_map_acquire(&l->dep_map); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/lockdep.h:541:69: note: expanded from macro 'lock_map_acquire' 541 | #define lock_map_acquire(l) lock_acquire_exclusive(l, 0, 0, NULL, _THIS_IP_) | ^~~~~~~~~ In file included from lib/test_context-analysis.c:9: In file included from include/linux/local_lock.h:5: include/linux/local_lock_internal.h:53:2: error: use of undeclared identifier '_THIS_IP_' 53 | lock_map_acquire_try(&l->dep_map); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/lockdep.h:542:73: note: expanded from macro 'lock_map_acquire_try' 542 | #define lock_map_acquire_try(l) lock_acquire_exclusive(l, 0, 1, NULL, _THIS_IP_) | ^~~~~~~~~ In file included from lib/test_context-analysis.c:9: In file included from include/linux/local_lock.h:5: include/linux/local_lock_internal.h:62:2: error: use of undeclared identifier '_THIS_IP_' 62 | lock_map_release(&l->dep_map); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/lockdep.h:545:47: note: expanded from macro 'lock_map_release' 545 | #define lock_map_release(l) lock_release(l, _THIS_IP_) | ^~~~~~~~~ 3 errors generated. The following diff resolves it for me, should I send it as a separate patch or do you want to just fold it in with a note? diff --git a/include/linux/lockdep.h b/include/linux/lockdep.h index 621566345406..2301a701ffbb 100644 --- a/include/linux/lockdep.h +++ b/include/linux/lockdep.h @@ -10,6 +10,7 @@ #ifndef __LINUX_LOCKDEP_H #define __LINUX_LOCKDEP_H +#include <linux/instruction_pointer.h> #include <linux/lockdep_types.h> #include <linux/smp.h> #include <asm/percpu.h> -- Cheers, Nathan