Re: [PATCH v4 2/2] tracing: Remove trace_printk.h from kernel.h
Nathan Chancellor <[email protected]> Fri, 26 Jun 2026 12:03:25 -0700
| Newsgroups | gmane.comp.freedesktop.xorg.drivers.intel,gmane.linux.kernel,gmane.linux.documentation,gmane.linux.kbuild.devel,gmane.linux.ports.ppc64.devel,gmane.comp.video.dri.devel,gmane.linux.ports.arm.kernel,gmane.linux.drivers.rdma,gmane.linux.usb.general,gmane.comp.file-systems.ext4,gmane.linux.nfs,gmane.comp.emulators.kvm.devel |
|---|---|
| Message-ID | <20260626190325.GA3913132@ax162> |
On Fri, Jun 26, 2026 at 04:51:19AM -0400, Steven Rostedt wrote: > On Thu, 25 Jun 2026 16:41:58 -0700 > Nathan Chancellor <[email protected]> wrote: > > > > The following diff resolves it for me, should I send it as a separate > > patch or do you want to just fold it in with a note? > > > > diff --git a/include/linux/lockdep.h b/include/linux/lockdep.h > > index 621566345406..2301a701ffbb 100644 > > --- a/include/linux/lockdep.h > > +++ b/include/linux/lockdep.h > > @@ -10,6 +10,7 @@ > > #ifndef __LINUX_LOCKDEP_H > > #define __LINUX_LOCKDEP_H > > > > +#include <linux/instruction_pointer.h> > > Ah, so the reason for this breakage is because lockdep was relying on > instruction_pointer.h, that just happened to be included in kernel.h > via trace_printk.h. Correct. > This is a separate issue, so it should be a separate patch. I'll add it > as patch 1 of this series. Sounds good, thanks! > Can you send me the config you used. This didn't trigger in my tests. It is a plain allmodconfig, for example on arm: $ make -skj"$(nproc)" ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- allmodconfig lib/test_context-analysis.o In file included from include/linux/local_lock_internal.h:8, from include/linux/local_lock.h:5, from lib/test_context-analysis.c:9: include/linux/local_lock_internal.h: In function 'local_lock_acquire': include/linux/lockdep.h:541:87: error: '_THIS_IP_' undeclared (first use in this function) 541 | #define lock_map_acquire(l) lock_acquire_exclusive(l, 0, 0, NULL, _THIS_IP_) | ^~~~~~~~~ include/linux/lockdep.h:509:88: note: in definition of macro 'lock_acquire_exclusive' 509 | #define lock_acquire_exclusive(l, s, t, n, i) lock_acquire(l, s, t, 0, 1, n, i) | ^ include/linux/local_lock_internal.h:46:9: note: in expansion of macro 'lock_map_acquire' 46 | lock_map_acquire(&l->dep_map); | ^~~~~~~~~~~~~~~~ include/linux/lockdep.h:541:87: note: each undeclared identifier is reported only once for each function it appears in ... I also reproduced it on top of allnoconfig: $ cat allno.config CONFIG_CONTEXT_ANALYSIS_TEST=y CONFIG_DEBUG_KERNEL=y CONFIG_DEBUG_LOCK_ALLOC=y CONFIG_EXPERT=y CONFIG_MMU=y CONFIG_RUNTIME_TESTING_MENU=y $ make -skj"$(nproc)" ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- KCONFIG_ALLCONFIG=1 clean allnoconfig lib/test_context-analysis.o <same error as above> -- Cheers, Nathan