Re: [PATCH] scripts/tags.sh: Prevent binary files appearing in cscope.files

Miguel Ojeda <[email protected]> Sun, 5 Jul 2026 20:05:25 +0200

Newsgroups	gmane.linux.kbuild.devel,gmane.linux.kernel.rust,gmane.linux.kernel
Message-ID	<CANiq72kHbVQfNrum5D2a5sCd3mFQHNtigrQxP1WW=YcggxA=WQ@mail.gmail.com>

On Sun, Jul 5, 2026 at 7:59 PM Sergei Litvin <[email protected]> wrote:
>
> PROBLEM

> SOLUTION

We don't typically use titles like these in commits. (Same for the other patch.)

> This causes `make cscope` command to generate a `cscope.files` file that
> contains *.rs files along with *.h, *.c, *.S

Missing Signed-off-by -- the one you wrote is below, in the part that
doesn't go into the commit, i.e. after the `---` line. (Same for the
other patch.)

Also consider using `-v2` in `git format-patch` to annotate which version it is.

By the way, this sounds like it could be backported? i.e. perhaps we
want a Fixes: tag and Cc: [email protected].

Thanks!

Cheers,
Miguel