Re: [PATCH v4 08/12] mips: Get rid of custom mips ABIs for syscall tables
André Almeida <[email protected]>
| Newsgroups | gmane.linux.kernel,gmane.linux.kbuild.devel |
|---|---|
| Message-ID | <[email protected]> |
Em 12/08/2026 06:16, Arnd Bergmann escreveu: > On Wed, Aug 12, 2026, at 05:33, André Almeida wrote: >> Get rid of the mips exclusive ABIs for the syscall tables and replace them >> with the common ABI names, replacing n32 and o32 with 32 and n64 with 64. >> >> No functional change happens, but it simplifies and helps to unify the >> tables. >> >> Signed-off-by: André Almeida <[email protected]> > > I had expected you to use 'common' instead of '32' and '64' here. Since you > did not combine the n32/n64 tables, this makes no practical difference, > but it still makes the tables look different from all the other ones, and > it means that the following patch to unify the tables is harder to > validate since the inputs are still not line-identical. > > Is there some reason you went with this approach? > Ops, no good reason here, it was a mistake :) I will redo it to use common from [1, 211] syscalls. What about o32? Should I kept it as o32, giving that it doesn't make much difference?