Re: [PATCH] erofs: Fix EROFS_FS_ZIP_LZMA_DEFAULT_MAX_STREAMS default logic
Geert Uytterhoeven <[email protected]>
| Newsgroups | gmane.linux.kernel,gmane.linux.kbuild.devel |
|---|---|
| Message-ID | <CAMuHMdXwmCrzLZiPnQejJ+dTvVNf2zTzgKwTWEFEkfKRkZQpPQ@mail.gmail.com> |
Hi Nicolas, On Fri, 28 Aug 2026 at 17:47, Nicolas Schier <[email protected]> wrote: > On Thu, Aug 20, 2026 at 12:15:33PM +0200, Geert Uytterhoeven wrote: > > On Thu, 20 Aug 2026 at 12:01, Geert Uytterhoeven > > <[email protected]> wrote: > > > When NR_CPUS is less than 16, or when SMP is disabled, the default value > > > of 16 is invalid. > > > > > > While actual configuration picks up a sensible and valid default > > > (NR_CPUS or 1), "make savedefconfig" will still write a line like > > > > > > CONFIG_EROFS_FS_ZIP_LZMA_DEFAULT_MAX_STREAMS=1 > > > > > > to the defconfig file, even if that matches the sensible default. > > > > Is this a bug in kconfig? > > I am not able to reproduce that; this is what I see with ARCH=arm64 > (arm64 always has SMP=y): [...] > Thus, to me it looks as expected. Do you still see the behaviour you > described above? Perhaps you cannot reproduce this because this fix is already upstream as commit ab74edaeb1ae7c71 ("erofs: Fix EROFS_FS_ZIP_LZMA_DEFAULT_MAX_STREAMS default logic")? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds