Re: GenHash problems

Jan Hugo Prins <[email protected]>
Newsgroups gmane.linux.keepalived.devel
Message-ID <[email protected]>
done,

Thanks
Jan Hugo


On 04/07/2014 12:51 PM, Frank Baalbergen wrote:
> Hi Jan Hugo,
>
> Just checked the diff again, i looked at the wrong file. It is weird
> that REQUEST_TEMPLATE_IPV6 is different in genhash/http.h and
> include/check_http.h.
>
> You can do a pull request at https://github.com/acassen/keepalived
> with your patch.
>
> Regards,
>
> Frank
>
> On 04/07/2014 12:48 PM, Frank Baalbergen wrote:
>> Hi Jan Hugo,
>>
>> If i look at your patch I see that your change won't have any affect on
>> current master. See the following source code:
>>
>> https://github.com/acassen/keepalived/blob/master/genhash/http.h
>>
>> If you check the original commit:
>>
>> https://github.com/acassen/keepalived/commit/ea9a1b6d3467b0341671ae4ba03d8f2412eca66a
>>
>>
>>
>> You see that the Host header is already `Host: [%s]%s\r\n\r\n`.
>>
>> Regards,
>>
>> Frank
>>
>
>


------------------------------------------------------------------------------
Put Bad Developers to Shame
Dominate Development with Jenkins Continuous Integration
Continuously Automate Build, Test & Deployment 
Start a new project now. Try Jenkins in the cloud.
http://p.sf.net/sfu/13600_Cloudbees_APR
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.