[acassen/keepalived] 2b6f91: ipvs_syncd_cmd uses memset() to zero the daemonrul...

  Branch: refs/heads/master
  Home:   https://github.com/acassen/keepalived
  Commit: 2b6f91dbcaccd08f14f41af0bb7b33a3889a88c3
      https://github.com/acassen/keepalived/commit/2b6f91dbcaccd08f14f41af0bb7b33a3889a88c3
  Author: John Sullivan <[email protected]>
  Date:   2014-04-09 (Wed, 09 Apr 2014)

  Changed paths:
    M keepalived/check/check_daemon.c
    M keepalived/vrrp/vrrp_daemon.c

  Log Message:
  -----------
  ipvs_syncd_cmd uses memset() to zero the daemonrule buffer before
populating it and sending it up. daemonrule is malloc()ed by
ipvs_start(). ipvs_start() can bail early if it can't communicate with
ipvs. Neither place which call ipvs_start() check the return value,
allowing them to walk straight into a NULL pointer deref.


  Commit: d36e2ae1963f4ff55fc52cbad145f8ab755c2a2e
      https://github.com/acassen/keepalived/commit/d36e2ae1963f4ff55fc52cbad145f8ab755c2a2e
  Author: John Sullivan <[email protected]>
  Date:   2014-04-09 (Wed, 09 Apr 2014)

  Changed paths:
    M doc/keepalived.conf.SYNOPSIS
    M doc/man/man5/keepalived.conf.5
    M keepalived/check/check_parser.c
    M keepalived/check/ipwrapper.c

  Log Message:
  -----------
  Without inhibit_on_failure on a real_server, when the server is marked
down existing TCP connections to it are simply blackholed. Hence
inhibit_on_failure: by setting the weight to zero no new connections
are sent to that server, but because the server isn't completely
removed from the table existing connections are allowed to continue.

The same problem exists with sorry_server. When a real_server comes
back up the sorry_server is removed from the pool and existing
connections are blackholed. Instead of continued service, which may
usually be a fast response indicating overload, the client must engage
in a lengthy wait for the connection to time out. It would be better
in many cases to allow the sorry_server connections to complete
naturally.

Luckily the code is structured well enough that all is required to get
this behaviour is to set the inhibit member of the sorry_server
structure, which is mostly just a change to the config file parser.


  Commit: 1a00bf275baeb010992f1e411bacd3a7d99fe705
      https://github.com/acassen/keepalived/commit/1a00bf275baeb010992f1e411bacd3a7d99fe705
  Author: Alexandre Cassen <[email protected]>
  Date:   2014-04-28 (Mon, 28 Apr 2014)

  Changed paths:
    M doc/keepalived.conf.SYNOPSIS
    M doc/man/man5/keepalived.conf.5
    M keepalived/check/check_daemon.c
    M keepalived/check/check_parser.c
    M keepalived/check/ipwrapper.c
    M keepalived/vrrp/vrrp_daemon.c

  Log Message:
  -----------
  Merge pull request #76 from jsgh/master

fix segfault if ipvs can't be started


Compare: https://github.com/acassen/keepalived/compare/5bd4d2cf3d70...1a00bf275bae

------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.  Get 
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs

_______________________________________________
Keepalived-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/keepalived-devel