[acassen/keepalived] 4440db: Revert "Honor preempt_delay setting on startup."

  Branch: refs/heads/master
  Home:   https://github.com/acassen/keepalived
  Commit: 4440db7b5c692f254356fd3e4c7f2e7f2464dccd
      https://github.com/acassen/keepalived/commit/4440db7b5c692f254356fd3e4c7f2e7f2464dccd
  Author: Tore Anderson <[email protected]>
  Date:   2014-04-30 (Wed, 30 Apr 2014)

  Changed paths:
    M keepalived/vrrp/vrrp.c

  Log Message:
  -----------
  Revert "Honor preempt_delay setting on startup."

This reverts commit c7a985db4136b374dbee25caa39aa121bc16fb7d, and
fixes #80.

This commit resulted in two individual bugs:

1) A keepalived instance coming on-line would not transition to MASTER
state until the preempt_delay duration had passed, even though there was
no already existing VRRP speaker in MASTER state on the link. In other
words, it changed the semantics of preempt_delay from a delay that only
took place before *preemption* of another VRRP speaker, to a delay that
unconditionally took place after Keepalived came online. The
keepalived.conf manual page has always documented the former meaning,
which is also IMHO the only one that you would intuitively expect.

2) The preempt_delay was applied when a Keepalived process was reloading
its configuration following the recipt of SIGHUP. If the Keepalived
instance was in MASTER state before the reload, it would cease
transmitting VRRP hellos for the duration of preempt_delay, but *not*
actually remove the virtual addresses from the network interfaces. This
in turn resulted in any backup VRRP speakers on the links transition to
the MASTER state while preempt_delay was still in effect on the original
MASTER that was reloaded, thus creating a service-impacting split-brain
scenario where the virtual addresses are present and active on multiple
VRRP speakers simultaneously.

If the functionality that c7a985d aimed to implement really is needed in
Keepalived, it should instead be implemented using a separate
configuration setting independent from preempt_delay. An appropriate
name for this new setting could be for example "startup_delay" or
"initial_delay". However, it could also be implemented in the init
script, by starting keepalived with e.g. "sleep N && keepalived" where N
would be the desired duration of the initial/startup delay.


  Commit: 8a8e899388e08036b8dba1ba6d2c76a9a315dcad
      https://github.com/acassen/keepalived/commit/8a8e899388e08036b8dba1ba6d2c76a9a315dcad
  Author: Alexandre Cassen <[email protected]>
  Date:   2014-04-30 (Wed, 30 Apr 2014)

  Changed paths:
    M keepalived/vrrp/vrrp.c

  Log Message:
  -----------
  Merge pull request #82 from toreanderson/fix-preempt_delay

Revert "Honor preempt_delay setting on startup."


Compare: https://github.com/acassen/keepalived/compare/dc2773e94fe6...8a8e899388e0

------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.  Get 
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs

_______________________________________________
Keepalived-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/keepalived-devel