Failure to remove VMAC interface reports both failure and success

Quentin Armitage <[email protected]>
Newsgroups gmane.linux.keepalived.devel
Organization The Armitage family
Message-ID <[email protected]>
If the VMAC interface removal fails, I get the following 2 messages in
the log:
    Jul  5 15:33:51 joseph Keepalived_vrrp[19950]: vmac: Error removing
VMAC interface vrrp.52 for vrrp_instance VI_4!!!
    Jul  5 15:33:51 joseph Keepalived_vrrp[19950]: vmac: Success
removing VMAC interface vrrp.52 for vrrp_instance VI_4

This is caused by the following code in vrrp_vmac.c:

int
netlink_link_del_vmac(vrrp_t *vrrp)
{
        int status = 1;

#ifdef _HAVE_VRRP_VMAC_
    
 . . .

        if (netlink_talk(&nl_cmd, &req.n) < 0) {
                log_message(LOG_INFO, "vmac: Error removing VMAC
interface %s for vrrp_instance %s!!!"
                                    , vrrp->vmac_ifname, vrrp->iname);
                status = -1;
        }

        log_message(LOG_INFO, "vmac: Success removing VMAC interface %s
for vrrp_instance %s"
                            , vrrp->vmac_ifname, vrrp->iname);
#endif

        return status;
}

Where it sets "status = -1;", instead it should execute "return -1;".

Quentin Armitage

------------------------------------------------------------------------------
Open source business process management suite built on Java and Eclipse
Turn processes into business applications with Bonita BPM Community Edition
Quickly connect people, data, and systems into organized workflows
Winner of BOSSIE, CODIE, OW2 and Gartner awards
http://p.sf.net/sfu/Bonitasoft

_______________________________________________
Keepalived-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/keepalived-devel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.