Re: Problem with notify script

Including current maintainers at Brocade.

-----Original Message-----
From: Ryan O'Hara [mailto:[email protected]] 
Sent: Thursday, June 18, 2015 6:39 AM
To: Alexandre Cassen
Cc: [email protected]; Sameer Agrawal
Subject: Re: [Keepalived-devel] Problem with notify script

On Thu, Jun 18, 2015 at 09:46:04AM +0200, Alexandre Cassen wrote:
> configuration should be updated with brack block as follow :
> 
> notify  {
>    /usr/local/bin/notify_vrrp.sh
> }

I see. I was not aware of this change. Thanks.

> but I am considering reverting that patch since it is breaking compat

Agreed. I am going to need to revert this in Fedora since it is breaking existing configurations. I see three possible solutions:

1. Revert the patch completely.
2. Make the notify keyword accept a list (brackets) or a single script (no brackets) as in 1.2.16 and earlier.
3. Use a new keyword to identify a list of scripts, then restore notify to accept just a single script.

Ryan

> On Thu, Jun 18, 2015 at 3:35 AM, Ryan O'Hara <[email protected]> wrote:
> 
> >
> > A problem with the notify script in version 1.2.17 was reported to 
> > me and I verified the issue this evening. In short, the notify 
> > script is not being executed. The other notification script 
> > (notify_master, notify_backup, notify_fault) seem to work just fine.
> >
> > While testing this, I had two VRRP instances defined in 
> > keepalived.conf. I noticed that if I had a notify script defined, 
> > the second VRRP instance was not being parsed, so I looked at 
> > changes to vrrp_parser.c. It seems that this patch [1]is causing the problem.
> >
> > The reporter of this bug also opened an issue on github, which can 
> > be found here [2].
> >
> > I'm considering reverting this patch, but a git revert of this 
> > commit is not clean so it may take a bit of work.
> >
> > Ryan
> >
> > [1]
> > https://github.com/acassen/keepalived/commit/5c4177381bee24f9f7fbe33
> > b8dc20c2d9cc2bccb [2] 
> > https://github.com/acassen/keepalived/issues/156
> >
> >
> > --------------------------------------------------------------------
> > ---------- _______________________________________________
> > Keepalived-devel mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/keepalived-devel
> >

------------------------------------------------------------------------------