[acassen/keepalived] e4aa2c: In free_list_elements invoke the free function if ...

  Branch: refs/heads/master
  Home:   https://github.com/acassen/keepalived
  Commit: e4aa2c74414ab7ce7f7da1f3bd047a77669685ae
      https://github.com/acassen/keepalived/commit/e4aa2c74414ab7ce7f7da1f3bd047a77669685ae
  Author: Quentin Armitage <[email protected]>
  Date:   2016-01-26 (Tue, 26 Jan 2016)

  Changed paths:
    M lib/list.c

  Log Message:
  -----------
  In free_list_elements invoke the free function if it exists

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: fc8a7f9896c439acc9b0c5fff63ceae17ce6cfef
      https://github.com/acassen/keepalived/commit/fc8a7f9896c439acc9b0c5fff63ceae17ce6cfef
  Author: Quentin Armitage <[email protected]>
  Date:   2016-01-26 (Tue, 26 Jan 2016)

  Changed paths:
    M keepalived/check/check_data.c
    M keepalived/vrrp/vrrp_data.c
    M lib/list.h

  Log Message:
  -----------
  Use of LIST_ISEMPTY to check list exists causes memory leak

If a list exists, but has 0 entries, the code fragment
if (LIST_ISEMPTY(list_p))
	list_p = list_alloc(..., ...)
causes the original list pointer to be overwritten, thereby causing a memory
leak.

Introducing LIST_EXISTS, and replacing the code fragment above with
if (!LIST_EXISTS(list_p))
	list_p = list_alloc(..., ...);
avoids the memory leak.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: ba770d770261c1a3e8cc0ee6d3cf185fef2d57d5
      https://github.com/acassen/keepalived/commit/ba770d770261c1a3e8cc0ee6d3cf185fef2d57d5
  Author: Quentin Armitage <[email protected]>
  Date:   2016-01-26 (Tue, 26 Jan 2016)

  Changed paths:
    M keepalived/vrrp/vrrp_ipaddress.c

  Log Message:
  -----------
  Stop parse_ipaddress FREEing via pointer passed to it

parse_ipaddress FREE'd new following an error, but new could be an address
passed to the function, and therefore might not be MALLOC'd memory.

This commit makes the caller of parse_ipaddress free the memory if there
is an error and the calling function MALLOC'd the memory.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 29840d59121acf366a6d300fd642a13784e458c2
      https://github.com/acassen/keepalived/commit/29840d59121acf366a6d300fd642a13784e458c2
  Author: Alexandre Cassen <[email protected]>
  Date:   2016-01-27 (Wed, 27 Jan 2016)

  Changed paths:
    M keepalived/check/check_data.c
    M keepalived/vrrp/vrrp_data.c
    M keepalived/vrrp/vrrp_ipaddress.c
    M lib/list.c
    M lib/list.h

  Log Message:
  -----------
  Merge pull request #222 from pqarmitage/memory_leaks

Memory leaks - request #2


Compare: https://github.com/acassen/keepalived/compare/6ffa55288d53...29840d59121a

------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140

_______________________________________________
Keepalived-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/keepalived-devel