[acassen/keepalived] 3bc377: Streamline handling of daemon mode flags

Alexandre Cassen <[email protected]>
Newsgroups gmane.linux.keepalived.devel
Message-ID <56c21f5b3ca37_3f103fe2572f12b858220@hookshot-fe4-cp1-prd.iad.github.net.mail>
  Branch: refs/heads/master
  Home:   https://github.com/acassen/keepalived
  Commit: 3bc3772876f56f7e8a15c2695f5c5b7880b2f99b
      https://github.com/acassen/keepalived/commit/3bc3772876f56f7e8a15c2695f5c5b7880b2f99b
  Author: Quentin Armitage <[email protected]>
  Date:   2016-02-14 (Sun, 14 Feb 2016)

  Changed paths:
    M keepalived/core/main.c
    M keepalived/core/pidfile.c
    M keepalived/include/main.h

  Log Message:
  -----------
  Streamline handling of daemon mode flags

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 6e6b8e6792c55be4efc6d806e0556965f5952890
      https://github.com/acassen/keepalived/commit/6e6b8e6792c55be4efc6d806e0556965f5952890
  Author: Quentin Armitage <[email protected]>
  Date:   2016-02-14 (Sun, 14 Feb 2016)

  Changed paths:
    M keepalived/core/pidfile.c

  Log Message:
  -----------
  Improve handling of not being able to read a pid file

If a pid file was opened, but for some reason a pid could not
successfully be read, the pid used to check if a process was
running was random.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 22741a4e21f3d4861eb44fa685e8f7b093d9685b
      https://github.com/acassen/keepalived/commit/22741a4e21f3d4861eb44fa685e8f7b093d9685b
  Author: Quentin Armitage <[email protected]>
  Date:   2016-02-14 (Sun, 14 Feb 2016)

  Changed paths:
    M keepalived/include/pidfile.h

  Log Message:
  -----------
  Remove unused pid filename definitions

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 3fbd1ac5ef0bb6c4c48270ae4ac0fc4e53740ae7
      https://github.com/acassen/keepalived/commit/3fbd1ac5ef0bb6c4c48270ae4ac0fc4e53740ae7
  Author: Quentin Armitage <[email protected]>
  Date:   2016-02-14 (Sun, 14 Feb 2016)

  Changed paths:
    M lib/memory.c
    M lib/scheduler.c

  Log Message:
  -----------
  Change outstanding debug flag tests to use bitops helpers

There were two cases where fixed numbers, rather than defined values,
were used to test the debug flag. This commit changes them to use the
defined values and the bitops helpers.

I'm not sure of the logic in scheduler.c of testing for MEM_ERR_DETECT
and DONT_RELEASE_VRRP, but that is what was happening, even prior to
the introduction of bitops.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 7941a64a52d3fba5ada2c626a594c0068185557c
      https://github.com/acassen/keepalived/commit/7941a64a52d3fba5ada2c626a594c0068185557c
  Author: Quentin Armitage <[email protected]>
  Date:   2016-02-14 (Sun, 14 Feb 2016)

  Changed paths:
    M lib/bitops.h

  Log Message:
  -----------
  Allow for different sizes of long ints in bitops

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: ab0a8c98f07ee41a8697830e160117462fd1b107
      https://github.com/acassen/keepalived/commit/ab0a8c98f07ee41a8697830e160117462fd1b107
  Author: Quentin Armitage <[email protected]>
  Date:   2016-02-14 (Sun, 14 Feb 2016)

  Changed paths:
    M keepalived/vrrp/vrrp.c
    M keepalived/vrrp/vrrp_data.c
    M keepalived/vrrp/vrrp_print.c
    M keepalived/vrrp/vrrp_snmp.c

  Log Message:
  -----------
  Ensure conversions of vrrp->adver_int etc don't overflow

Conversions of vrrp->adver_int and vrrp->master_adver_int into
milli-seconds or centi-seconds would overflow if the advertisement
interval were sufficiently long (2.5 seconds would cause the
problem converting to milli-seconds).

The calculations were, for example:
(adver_int * 1000) / TIMER_HZ
which has been altered to:
adver_int / (TIMER_HZ / 1000)

The problem is that adver_int is in microseconds, and so
2.5 * 1000000 * 1000 overflowed a 4 byte signed int.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 1bbfd4f9524f7ae0fff419037fc0ebb34f07d3b5
      https://github.com/acassen/keepalived/commit/1bbfd4f9524f7ae0fff419037fc0ebb34f07d3b5
  Author: Alexandre Cassen <[email protected]>
  Date:   2016-02-15 (Mon, 15 Feb 2016)

  Changed paths:
    M keepalived/core/main.c
    M keepalived/core/pidfile.c
    M keepalived/include/main.h
    M keepalived/include/pidfile.h
    M keepalived/vrrp/vrrp.c
    M keepalived/vrrp/vrrp_data.c
    M keepalived/vrrp/vrrp_print.c
    M keepalived/vrrp/vrrp_snmp.c
    M lib/bitops.h
    M lib/memory.c
    M lib/scheduler.c

  Log Message:
  -----------
  Merge pull request #247 from pqarmitage/fixes

Sundry changes


Compare: https://github.com/acassen/keepalived/compare/2297a27ef82f...1bbfd4f9524f

------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140

_______________________________________________
Keepalived-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/keepalived-devel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.