[acassen/keepalived] df408d: Make lvs_sync_daemon global config rather than vrr...

Alexandre Cassen <[email protected]>
Newsgroups gmane.linux.keepalived.devel
Message-ID <56e934d2d7473_26083f85a96932a075415a@hookshot-fe3-cp1-prd.iad.github.net.mail>
  Branch: refs/heads/master
  Home:   https://github.com/acassen/keepalived
  Commit: df408d819b3263c82d69d700719f6fe1799933e6
      https://github.com/acassen/keepalived/commit/df408d819b3263c82d69d700719f6fe1799933e6
  Author: Quentin Armitage <[email protected]>
  Date:   2016-03-15 (Tue, 15 Mar 2016)

  Changed paths:
    M doc/keepalived.conf.SYNOPSIS
    M doc/man/man5/keepalived.conf.5
    M keepalived/core/global_data.c
    M keepalived/core/global_parser.c
    M keepalived/include/global_data.h
    M keepalived/include/vrrp.h
    M keepalived/vrrp/vrrp.c
    M keepalived/vrrp/vrrp_daemon.c
    M keepalived/vrrp/vrrp_data.c
    M keepalived/vrrp/vrrp_netlink.c
    M keepalived/vrrp/vrrp_parser.c
    M keepalived/vrrp/vrrp_print.c
    M keepalived/vrrp/vrrp_scheduler.c
    M keepalived/vrrp/vrrp_snmp.c

  Log Message:
  -----------
  Make lvs_sync_daemon global config rather than vrrp specific

Issue #237, and various emails over the years have indicated
confusion due to lvs_sync_daemon being configured on the vrrp
instances, and hence suggesting that it could be configured
on multiple vrrp instances.

This commit changes how the lvs_sync_daemon is configured, so
that it is part of the global configuration, and not configured
within a specific vrrp_instance. In order not to break any existing
configurations, configuring lvs_sync_daemon within a vrrp instance
is still supported, but logged as deprecated. In addition, if
lvs_sync_daemon is configured on more than one vrrp_instance, an
error is logged.

In making this change, it was also discovered that when reloading
keepalived with a new configuration, if the lvs_sync_daemon was
moved onto a different vrrp instance, then depending on the order
of the vrrp instances, the lvs sync daemon could be started on the
new instance (which would fail) but then subsequently stopped on the
old instance, leaving the sync daemon not running.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 9f9fa8e5617942ed3d713c4cdc0a698dabc791fa
      https://github.com/acassen/keepalived/commit/9f9fa8e5617942ed3d713c4cdc0a698dabc791fa
  Author: Quentin Armitage <[email protected]>
  Date:   2016-03-15 (Tue, 15 Mar 2016)

  Changed paths:
    M keepalived/vrrp/vrrp_daemon.c

  Log Message:
  -----------
  Stop lvs sync daemons on restart in case of prior abnormal termination

If keepalived terminates abnormally, the lvs sync daemon may remain
running. When keepalived restarts, if the lvs sync daemon vrrp instance
restarts in backup mode, the old lvs sync master daemon would remain
running.

This commit stops the lvs sync daemon(s) when keepalived starts, allowing
the normal process to start the right sync daemon.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 83e5bae73e45ce596d0e1f24c0806b7b552759cf
      https://github.com/acassen/keepalived/commit/83e5bae73e45ce596d0e1f24c0806b7b552759cf
  Author: Quentin Armitage <[email protected]>
  Date:   2016-03-15 (Tue, 15 Mar 2016)

  Changed paths:
    M keepalived/check/check_daemon.c
    M keepalived/check/ipvswrapper.c
    M keepalived/include/ipvswrapper.h
    M keepalived/vrrp/vrrp.c
    M keepalived/vrrp/vrrp_daemon.c
    M keepalived/vrrp/vrrp_scheduler.c

  Log Message:
  -----------
  Remove any residual ipvs configuration on restart

If keepalived terminates abnormally, any ipvs server configuration
will remain, and so this commit makes keepalived remove any left over
configuration when starting up.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: ca37e727b4cfdffb08d99cd6829ca667a98b4e05
      https://github.com/acassen/keepalived/commit/ca37e727b4cfdffb08d99cd6829ca667a98b4e05
  Author: Quentin Armitage <[email protected]>
  Date:   2016-03-15 (Tue, 15 Mar 2016)

  Changed paths:
    M keepalived/vrrp/vrrp.c

  Log Message:
  -----------
  Optimise clear_diff_vrrp_*() functions

The clear_diff_vrrp_*() functions have to search for the matching
new vrrp interface, even though the calling function knows the
instance. This commit passes the new vrrp interface to each of the
functions.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 2dc8004980bb3f62b2816126d9c78c906c1a3a6e
      https://github.com/acassen/keepalived/commit/2dc8004980bb3f62b2816126d9c78c906c1a3a6e
  Author: Quentin Armitage <[email protected]>
  Date:   2016-03-15 (Tue, 15 Mar 2016)

  Changed paths:
    M lib/parser.c

  Log Message:
  -----------
  Check MALLOC returned non NULL before copying to the location

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 79cb96a4f222d1f696210e54e87b1417a34264b4
      https://github.com/acassen/keepalived/commit/79cb96a4f222d1f696210e54e87b1417a34264b4
  Author: Quentin Armitage <[email protected]>
  Date:   2016-03-15 (Tue, 15 Mar 2016)

  Changed paths:
    M keepalived/check/check_parser.c

  Log Message:
  -----------
  Fix compiler warning

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: b782656cc6a74ef21189ccbc6d64ef78f35ffd37
      https://github.com/acassen/keepalived/commit/b782656cc6a74ef21189ccbc6d64ef78f35ffd37
  Author: Quentin Armitage <[email protected]>
  Date:   2016-03-16 (Wed, 16 Mar 2016)

  Changed paths:
    M doc/keepalived.conf.SYNOPSIS
    M doc/man/man5/keepalived.conf.5
    M keepalived/core/global_data.c
    M keepalived/core/global_parser.c
    M keepalived/include/global_data.h
    M keepalived/vrrp/vrrp.c
    M keepalived/vrrp/vrrp_daemon.c
    M keepalived/vrrp/vrrp_scheduler.c

  Log Message:
  -----------
  Allxoow specifying syncid for lvs syncd

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 79307645442deb624bc93e3a6aa290d802a15777
      https://github.com/acassen/keepalived/commit/79307645442deb624bc93e3a6aa290d802a15777
  Author: Alexandre Cassen <[email protected]>
  Date:   2016-03-16 (Wed, 16 Mar 2016)

  Changed paths:
    M doc/keepalived.conf.SYNOPSIS
    M doc/man/man5/keepalived.conf.5
    M keepalived/check/check_daemon.c
    M keepalived/check/check_parser.c
    M keepalived/check/ipvswrapper.c
    M keepalived/core/global_data.c
    M keepalived/core/global_parser.c
    M keepalived/include/global_data.h
    M keepalived/include/ipvswrapper.h
    M keepalived/include/vrrp.h
    M keepalived/vrrp/vrrp.c
    M keepalived/vrrp/vrrp_daemon.c
    M keepalived/vrrp/vrrp_data.c
    M keepalived/vrrp/vrrp_netlink.c
    M keepalived/vrrp/vrrp_parser.c
    M keepalived/vrrp/vrrp_print.c
    M keepalived/vrrp/vrrp_scheduler.c
    M keepalived/vrrp/vrrp_snmp.c
    M lib/parser.c

  Log Message:
  -----------
  Merge pull request #279 from pqarmitage/fixes

Configure LVS syncd at global level, a few other lvs syncd changes and three minor fixes


Compare: https://github.com/acassen/keepalived/compare/f3a89c6a2fe0...79307645442d

------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140

_______________________________________________
Keepalived-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/keepalived-devel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.