[acassen/keepalived] 0e236c: In free_interface_queue, don't check LIST_ISEMPTY ...

  Branch: refs/heads/master
  Home:   https://github.com/acassen/keepalived
  Commit: 0e236c26260eb7b1f54650398eef753995346123
      https://github.com/acassen/keepalived/commit/0e236c26260eb7b1f54650398eef753995346123
  Author: Quentin Armitage <[email protected]>
  Date:   2016-05-23 (Mon, 23 May 2016)

  Changed paths:
    M keepalived/vrrp/vrrp_if.c

  Log Message:
  -----------
  In free_interface_queue, don't check LIST_ISEMPTY before freeing

LIST_ISEMPTY() returns false if the queue exists, but there are no
entries on the queue. If free_list is only called is !(LIST_ISEMPTY)
then the queue struct itself will not be freed.

This commit removes the check of LIST_ISEMPTY, to ensure that the
queue structure itself will always be freed.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: afc7dce37bb1b26abd15b03990fdbab427ecd1ea
      https://github.com/acassen/keepalived/commit/afc7dce37bb1b26abd15b03990fdbab427ecd1ea
  Author: Quentin Armitage <[email protected]>
  Date:   2016-05-23 (Mon, 23 May 2016)

  Changed paths:
    M keepalived/check/check_api.c
    M keepalived/check/check_data.c
    M keepalived/check/check_http.c
    M keepalived/check/check_smtp.c
    M keepalived/check/ipwrapper.c
    M keepalived/core/global_data.c
    M keepalived/vrrp/vrrp_data.c
    M keepalived/vrrp/vrrp_if.c
    M keepalived/vrrp/vrrp_scheduler.c
    M lib/list.c
    M lib/list.h
    M lib/rttables.c

  Log Message:
  -----------
  Clear pointer freed by free_list()

free_list() was specified as free_list(list l), and at the end of the
function it set l = NULL; however this was only setting the passed copy
of the pointer to NULL, which had no effect.

This commit changes free_list to be free_list(list *lp), so that setting
*lp = NULL; clears the original pointer.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 84999177c410267ef27d5c5459442a15b6af2578
      https://github.com/acassen/keepalived/commit/84999177c410267ef27d5c5459442a15b6af2578
  Author: Quentin Armitage <[email protected]>
  Date:   2016-05-23 (Mon, 23 May 2016)

  Changed paths:
    M lib/memory.h

  Log Message:
  -----------
  Make FREE_PTR() clear the pointer after freeing the memory

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 75f3e9e9b6091208f6824a321add74d23afa228c
      https://github.com/acassen/keepalived/commit/75f3e9e9b6091208f6824a321add74d23afa228c
  Author: Quentin Armitage <[email protected]>
  Date:   2016-05-23 (Mon, 23 May 2016)

  Changed paths:
    M lib/memory.h

  Log Message:
  -----------
  Make FREE() clear pointer after memory released

Since a pointer to allocated memory mustn't be used after the memory is
freed, it is safer to clear the pointer. It also means that if the pointer
is subsequently used, it shoud segfault immediately rather than potentially
trampling over random memory, which might be very difficult to debug.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 4fc2014bc6f993e7269637e88f7fc8be64ce2828
      https://github.com/acassen/keepalived/commit/4fc2014bc6f993e7269637e88f7fc8be64ce2828
  Author: Quentin Armitage <[email protected]>
  Date:   2016-05-23 (Mon, 23 May 2016)

  Changed paths:
    M keepalived/vrrp/Makefile.in

  Log Message:
  -----------
  Fix typo in keepalived/vrrp/Makefile.in

The typo was introduced in commit 42dbac9.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 69e5372d19b78a4fdc22fcb55c630609d924dbcc
      https://github.com/acassen/keepalived/commit/69e5372d19b78a4fdc22fcb55c630609d924dbcc
  Author: Quentin Armitage <[email protected]>
  Date:   2016-05-24 (Tue, 24 May 2016)

  Changed paths:
    M doc/keepalived.conf.SYNOPSIS
    M doc/man/man5/keepalived.conf.5
    M keepalived/vrrp/vrrp.c
    M keepalived/vrrp/vrrp_data.c
    M keepalived/vrrp/vrrp_parser.c

  Log Message:
  -----------
  Improve validation of advert_int

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: b6e2eb2f6f75200a00cc2951f2e894d56b77b107
      https://github.com/acassen/keepalived/commit/b6e2eb2f6f75200a00cc2951f2e894d56b77b107
  Author: Alexandre Cassen <[email protected]>
  Date:   2016-05-24 (Tue, 24 May 2016)

  Changed paths:
    M doc/keepalived.conf.SYNOPSIS
    M doc/man/man5/keepalived.conf.5
    M keepalived/check/check_api.c
    M keepalived/check/check_data.c
    M keepalived/check/check_http.c
    M keepalived/check/check_smtp.c
    M keepalived/check/ipwrapper.c
    M keepalived/core/global_data.c
    M keepalived/vrrp/Makefile.in
    M keepalived/vrrp/vrrp.c
    M keepalived/vrrp/vrrp_data.c
    M keepalived/vrrp/vrrp_if.c
    M keepalived/vrrp/vrrp_parser.c
    M keepalived/vrrp/vrrp_scheduler.c
    M lib/list.c
    M lib/list.h
    M lib/memory.h
    M lib/rttables.c

  Log Message:
  -----------
  Merge pull request #340 from pqarmitage/fixes

Fix typo in a Makefile, and clear pointers after memory freed


Compare: https://github.com/acassen/keepalived/compare/055fcbff6969...b6e2eb2f6f75

------------------------------------------------------------------------------
Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
apps on BYO-devices by containerizing them, leaving personal data untouched!
https://ad.doubleclick.net/ddm/clk/304595813;131938128;j

_______________________________________________
Keepalived-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/keepalived-devel