Re: While 1.2.23 works perfectly with rpmbuild, 1.2.24 does not

Quentin Armitage <[email protected]>
Newsgroups gmane.linux.keepalived.devel
Organization The Armitage family
Message-ID <[email protected]>
On Fri, 2016-09-30 at 10:46 +0200, Bernd wrote:

> Hi,
> 
> building 1.2.23 using rpmbuild works perfectly fine.
> 
> Seems 1.2.24 had a regression somewhere, as it fails. Excerpt following.
> 
> Best regards,
> 
> Bernd



> + grep -q 'IPVS_SUPPORT='\''_WITH_LVS_'\''' config.log
> + echo 'ERROR: We do not want keeepalived lacking LVS support.'
> ERROR: We do not want keeepalived lacking LVS support.
> + exit 1
> error: Bad exit status from /var/tmp/rpm-tmp.tvvRWf (%check)
> 
> 

Unfortunately this was an oversight on my part when I converted the
build system to use automake. Commit 7016c55 resolves this problem. The
actual patch is:
diff --git a/keepalived.spec.in b/keepalived.spec.in
index 00cf0f2..507b2af 100644
--- a/keepalived.spec.in
+++ b/keepalived.spec.in
@@ -58,8 +69,8 @@ healthchecks and LVS directors failover.
 %check
 # A build could silently have LVS support disabled if the kernel
includes can't
 # be properly found, we need to avoid that.
-if ! grep -q "IPVS_SUPPORT='_WITH_LVS_'" config.log; then
-    echo "ERROR: We do not want keeepalived lacking LVS support."
+if ! grep -q "#define _WITH_LVS_ *1" lib/config.h; then
+    %{__echo} "ERROR: We do not want keepalived lacking LVS support."
     exit 1
 fi

but the commit also has some other changes.

------------------------------------------------------------------------------

_______________________________________________
Keepalived-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/keepalived-devel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.