Re: a question about check_http

On Wed, 2016-09-07 at 15:17 +0800, xcf733520 wrote:

> Hi All,
> 	I can not understand these codes(v1.2.23 in check_http.c) as below:
> 	/* Handle read timeout */
> 	if (thread->type == THREAD_WRITE_TIMEOUT)
> 		return timeout_epilog(thread, "Timeout WEB read");
> 	
> 	why not "Timeout WEB write"?


Apologies for the delay in replying to this.

You appear to be absolutely right in not understanding this. This bit of
code was originally added in commit 99169f8 (version 0.3.6). In this
commit, the error message was ""HTTP write timeout ...", but the comment
was
/* Handle read timeout */
to it looks like there was a bit of a copy and paste error when adding
the code block.

Commit 2ef6fab (version 0.4.9) changed to error message to match the
comment, and so report a read timeout, rather than changing the comment
to match the code and the error message!

I'll produce a patch to fix the comment and error message.

Many thanks for the report,

Quentin A

------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi

_______________________________________________
Keepalived-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/keepalived-devel