[acassen/keepalived] 0fbcb1: Correctly handle existing VMACs on reload

  Branch: refs/heads/master
  Home:   https://github.com/acassen/keepalived
  Commit: 0fbcb145ba679ca8e95a31e0d3285a15f492bda7
      https://github.com/acassen/keepalived/commit/0fbcb145ba679ca8e95a31e0d3285a15f492bda7
  Author: Quentin Armitage <[email protected]>
  Date:   2016-11-04 (Fri, 04 Nov 2016)

  Changed paths:
    M keepalived/vrrp/vrrp.c
    M keepalived/vrrp/vrrp_vmac.c

  Log Message:
  -----------
  Correctly handle existing VMACs on reload

Anthony Dempsey <[email protected]> in issue #449 identified that
keepalived attempts to recreate existing VMAC interfaces on a reload,
and that the subsequent failure causes keepalived not to use the VMAC.

This then identified further issues such as the check for an existing
VMAC in netlink_link_add_vmac() didn't also check the interface a
VMAC was on, and that the checks for conflicts of VMAC interface names
with existing interfaces weren't sufficient.

This patch builds on the patch provided by Anthony Dempsey to also
resolve the additional issues identified.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: aaea8a4ca0720d6f017c4c473e085f7b552acc3a
      https://github.com/acassen/keepalived/commit/aaea8a4ca0720d6f017c4c473e085f7b552acc3a
  Author: Quentin Armitage <[email protected]>
  Date:   2016-11-04 (Fri, 04 Nov 2016)

  Changed paths:
    M keepalived/vrrp/vrrp.c

  Log Message:
  -----------
  Fix check of matching VRRP instances on reload

On a reload, clear_diff_vrrp() removes vrrp instances that are no
longer in the configuration. The check, however, was based on vrrp
instance name, which might have changed. The check is now based on
VRID, address family and interface, since it is this triplet that
uniquely defines a vrrp instance.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 98d377ee2726493c956da70a2f241abcedeae7bc
      https://github.com/acassen/keepalived/commit/98d377ee2726493c956da70a2f241abcedeae7bc
  Author: pqarmitage <[email protected]>
  Date:   2016-11-04 (Fri, 04 Nov 2016)

  Changed paths:
    M keepalived/vrrp/vrrp.c
    M keepalived/vrrp/vrrp_vmac.c

  Log Message:
  -----------
  Merge pull request #450 from pqarmitage/fixes

Resolve finding, and reusing VMAC interfaces on reload, and deletion of ones no longer used


Compare: https://github.com/acassen/keepalived/compare/5cc4c097913f...98d377ee2726

------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi

_______________________________________________
Keepalived-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/keepalived-devel