misc_dynamic log issue

Chris Caputo <[email protected]>
Newsgroups gmane.linux.keepalived.devel
Message-ID <[email protected]>
misc_dynamic is defined as:

  # If set, exit code from healthchecker is used
  # to dynamically adjust the weight as follows:
  #   exit status 0: svc check success, weight
  #     unchanged.
  #   exit status 1: svc check failed.
  #   exit status 2-255: svc check success, weight
  #     changed to 2 less than exit status.
  #   (for example: exit status of 255 would set
  #     weight to 253)
  misc_dynamic

Recent changes to scheduler.c are causing frequent messages when there 
isn't actually a problem:

  Keepalived_healthcheckers[123]: pid 456 exited with status 255

With this in mind, would it make sense to make the following change to 
scheduler.c?

Thanks,
Chris

---

diff --git a/lib/scheduler.c b/lib/scheduler.c
index a898d1d..2328ad3 100644
--- a/lib/scheduler.c
+++ b/lib/scheduler.c
@@ -99,7 +99,7 @@ report_child_status(int status, pid_t pid, char const *prog_name)
 			return true;
 		}
 
-		if (exit_status != EXIT_SUCCESS)
+		if (exit_status == EXIT_FAILURE)
 			log_message(LOG_INFO, "%s exited with status %d", prog_id, exit_status);
 		return false;
 	}

------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/intel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.