[acassen/keepalived] 6652dc: Only declare (and use) auth variables if compiling...

pqarmitage <[email protected]> Fri, 15 Sep 2017 16:33:51 -0700
Newsgroups gmane.linux.keepalived.devel
Message-ID <59bc635fd0fb7_65593fb6c285dc30101442@hookshot-fe-92cdb05.cp1-iad.github.net.mail> 
  Branch: refs/heads/master
  Home:   https://github.com/acassen/keepalived
  Commit: 6652dc3949400ca3e4da1be9871ac6965c839305
      https://github.com/acassen/keepalived/commit/6652dc3949400ca3e4da1be9871ac6965c839305
  Author: Quentin Armitage <[email protected]>
  Date:   2017-09-02 (Sat, 02 Sep 2017)

  Changed paths:
    M keepalived/include/vrrp.h
    M keepalived/vrrp/vrrp_data.c
    M keepalived/vrrp/vrrp_print.c
    M keepalived/vrrp/vrrp_snmp.c

  Log Message:
  -----------
  Only declare (and use) auth variables if compiling with authentication

authtype_mismatch and auth_failure are only used if authentication is
enabled.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 22017812c48bb5a7858dd8ab80b736c54782ac2a
      https://github.com/acassen/keepalived/commit/22017812c48bb5a7858dd8ab80b736c54782ac2a
  Author: Quentin Armitage <[email protected]>
  Date:   2017-09-02 (Sat, 02 Sep 2017)

  Changed paths:
    M keepalived/include/vrrp_if.h
    M keepalived/vrrp/vrrp_vmac.c

  Log Message:
  -----------
  The vrrp_t vmac flag should be a bool

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 2f08ec41ea5fb56f080523d7adae2d7682d20cdb
      https://github.com/acassen/keepalived/commit/2f08ec41ea5fb56f080523d7adae2d7682d20cdb
  Author: Quentin Armitage <[email protected]>
  Date:   2017-09-02 (Sat, 02 Sep 2017)

  Changed paths:
    M keepalived/include/vrrp_print.h

  Log Message:
  -----------
  Add include guard for vrrp_print.h

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 046808b5ae77e5877fa44e1f12024523782e4dea
      https://github.com/acassen/keepalived/commit/046808b5ae77e5877fa44e1f12024523782e4dea
  Author: Quentin Armitage <[email protected]>
  Date:   2017-09-02 (Sat, 02 Sep 2017)

  Changed paths:
    M keepalived/vrrp/vrrp_data.c
    M keepalived/vrrp/vrrp_print.c

  Log Message:
  -----------
  Log some additional vrrp variables

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: eb64954512c3667f123e8620064eaaef5c859869
      https://github.com/acassen/keepalived/commit/eb64954512c3667f123e8620064eaaef5c859869
  Author: Quentin Armitage <[email protected]>
  Date:   2017-09-02 (Sat, 02 Sep 2017)

  Changed paths:
    M keepalived/vrrp/vrrp_print.c

  Log Message:
  -----------
  Print unicast peer addresses in /tmp/keepalived.data

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 8f714448b1eadbc6f2c848d002d4709db6a5a285
      https://github.com/acassen/keepalived/commit/8f714448b1eadbc6f2c848d002d4709db6a5a285
  Author: Quentin Armitage <[email protected]>
  Date:   2017-09-02 (Sat, 02 Sep 2017)

  Changed paths:
    M doc/keepalived.conf.SYNOPSIS
    M doc/man/man5/keepalived.conf.5
    M keepalived/vrrp/vrrp_ipaddress.c

  Log Message:
  -----------
  Allow broadcast address to be specified as '-' or '+'

When configuring an ip address with a broadcast address, allow the
use of - and + (like ip(8)) to clear or set the host specfic bits of
the address, i.e.

10.6.23.254/16 broadcast + result in a broadcast address of 10.6.255.255
10.6.23.254/16 broadcast - results in a broadcast address of 10.6.0.0

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 16d0d4b94f03eeb0fb4b77aa5c2df1f0a1df62a5
      https://github.com/acassen/keepalived/commit/16d0d4b94f03eeb0fb4b77aa5c2df1f0a1df62a5
  Author: Quentin Armitage <[email protected]>
  Date:   2017-09-02 (Sat, 02 Sep 2017)

  Changed paths:
    M doc/keepalived.conf.SYNOPSIS
    M doc/man/man5/keepalived.conf.5
    M lib/parser.c

  Log Message:
  -----------
  Add negative conditional configuration

A configuration line starting @main will only be included if
keepalived is started with option -i main.

This commit adds configuration option @^main, meaning that the
remainder of the configuration line will only be included if
-i main was NOT specified.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: bcf2936301a07e291addc9e12688ac15117e2bea
      https://github.com/acassen/keepalived/commit/bcf2936301a07e291addc9e12688ac15117e2bea
  Author: Quentin Armitage <[email protected]>
  Date:   2017-09-02 (Sat, 02 Sep 2017)

  Changed paths:
    M keepalived/vrrp/vrrp.c

  Log Message:
  -----------
  Fix checksum calculation for VRRPv3 IPv4 unicast

Issue 642 identified that Wireshark was reporting incorrect checksums
when using unicast peers with VRRPv3 and IPv4.

Commit 67275d2 resolved an issue of inconsistent calculation of
checksums (checksums in alternate packets were 0).

Wireshark was reporting incorrect checksums due to the IP address
being put in the pseudo IPv4 header for the calculation of the VRRP
checksum being 224.0.0.18. For unicast peers the address should be
the actual destination IP address. Since keepalived was doing the
same thing when a packet was received, it did not detect an incorrect
checksum.

There is now an issue of backward compatibility of keepalived prior to
this commit with keepalived from this commit onwards when using VRRPv3
with unicasting. Commit 67275d2 enabled VRRPv3 with more than one
unicast peer to work for the first time since VRRPv3 was introduced by
commit 02e1959. We can conclude therefore that no-one has been using
VRRPv3 with more than one unicast peer.

The next commit will introduce a mechanism to allow backward compatibility.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 0d52573947b7b0c486a2725cdfce0ea3ac89a035
      https://github.com/acassen/keepalived/commit/0d52573947b7b0c486a2725cdfce0ea3ac89a035
  Author: Quentin Armitage <[email protected]>
  Date:   2017-09-02 (Sat, 02 Sep 2017)

  Changed paths:
    M configure
    M configure.ac
    M doc/keepalived.conf.SYNOPSIS
    M doc/man/man5/keepalived.conf.5
    M keepalived/include/vrrp.h
    M keepalived/vrrp/vrrp.c
    M keepalived/vrrp/vrrp_data.c
    M keepalived/vrrp/vrrp_parser.c
    M keepalived/vrrp/vrrp_print.c
    M lib/config.h.in

  Log Message:
  -----------
  Make checksum change backwards compatible

This commits adds the ability of keepalived to revert to using the old
checksum calculation if it sees an advert that has an old checksum. This
means that if an old and a new version of keepalived are working
together, once the new version has seen an advert from an old version,
it will drop back to using the old style checksum, and so the two
keepalived instances will work together.

There is a slight problem with this, though. If the old version starts
when a new version is master, if will report bad checksums. This should
be fine, since keepalived should discard the adverts, time out and send
an advert which would make the new keepalived revert to old checksums.
Unfortunately, keepalived does not completely ignore bad adverts, since
it resets its master down timer, even for bad adverts, and so it never
times out. However, in this scenario, there will still remain one master
and all the other keepalived instances will be in backup state, and so
VRRP functionality is preserved.

As identified in commit bcf2936 until commit 67275d2 keepalived did not
work with VRRPv3 and more than one other unicast peer, so for migration
we only need to consider two unicast peers. To upgrade, first upgrade
the keepalived instance that is in backup mode. This will see old
checksums when it starts, and so start using old checksums. The other
keepalived instance can then be upgraded and it will also see old
checksums when it starts up. In order to switch to using new checksums,
temporarily add the following line in the configuration of each vrrp
instance that is in master state:

old_unicast_checksum never

and then reload the keepalived instance by sending it SIGHUP. After the
master has restarted, restart the backup with a SIGHUP, and they will
then be using new checksums. The temporary old_unicast_checksum never
lines can now be removed from the configuration.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: cb5d43c44d523a36aec7297bb496bd1709c40d00
      https://github.com/acassen/keepalived/commit/cb5d43c44d523a36aec7297bb496bd1709c40d00
  Author: Quentin Armitage <[email protected]>
  Date:   2017-09-03 (Sun, 03 Sep 2017)

  Changed paths:
    M keepalived/core/main.c

  Log Message:
  -----------
  Make --config-id option default to hostname

This is the equivalent of specifying --config-id `hostname -s`, and
makes it more straightforward to deploy the same configuration to
multiple hosts.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: faf4a876e11794b5a2ae598375a62bcdb1cc66a7
      https://github.com/acassen/keepalived/commit/faf4a876e11794b5a2ae598375a62bcdb1cc66a7
  Author: Quentin Armitage <[email protected]>
  Date:   2017-09-12 (Tue, 12 Sep 2017)

  Changed paths:
    M lib/notify.c

  Log Message:
  -----------
  Fix updating resolved notify script path names with parameters

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 72408511449ccaab699a5197f465643f978a2d9d
      https://github.com/acassen/keepalived/commit/72408511449ccaab699a5197f465643f978a2d9d
  Author: pqarmitage <[email protected]>
  Date:   2017-09-16 (Sat, 16 Sep 2017)

  Changed paths:
    M configure
    M configure.ac
    M doc/keepalived.conf.SYNOPSIS
    M doc/man/man5/keepalived.conf.5
    M keepalived/core/main.c
    M keepalived/include/vrrp.h
    M keepalived/include/vrrp_if.h
    M keepalived/include/vrrp_print.h
    M keepalived/vrrp/vrrp.c
    M keepalived/vrrp/vrrp_data.c
    M keepalived/vrrp/vrrp_ipaddress.c
    M keepalived/vrrp/vrrp_parser.c
    M keepalived/vrrp/vrrp_print.c
    M keepalived/vrrp/vrrp_snmp.c
    M keepalived/vrrp/vrrp_vmac.c
    M lib/config.h.in
    M lib/notify.c
    M lib/parser.c

  Log Message:
  -----------
  Merge pull request #651 from pqarmitage/fixes

Various fixed and enhancements


Compare: https://github.com/acassen/keepalived/compare/4fe26476ca0f...72408511449c

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

_______________________________________________
Keepalived-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/keepalived-devel