[acassen/keepalived] 2742d7: Fix compilations warnings with older kernels

pqarmitage <[email protected]> Sun, 29 Oct 2017 01:40:22 -0700
Newsgroups gmane.linux.keepalived.devel
Message-ID <59f593f61e7a1_48943fd79d66dc30825a4@hookshot-fe-92cdb05.cp1-iad.github.net.mail>
  Branch: refs/heads/master
  Home:   https://github.com/acassen/keepalived
  Commit: 2742d76b62df81ae534ef7c2e12088e81f2116a6
      https://github.com/acassen/keepalived/commit/2742d76b62df81ae534ef7c2e12088e81f2116a6
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-17 (Tue, 17 Oct 2017)

  Changed paths:
    M keepalived/vrrp/vrrp_if_config.c

  Log Message:
  -----------
  Fix compilations warnings with older kernels

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 465c14ffabc4c21abc75f95145edb3bb40ae31fb
      https://github.com/acassen/keepalived/commit/465c14ffabc4c21abc75f95145edb3bb40ae31fb
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-19 (Thu, 19 Oct 2017)

  Changed paths:
    M lib/scheduler.c

  Log Message:
  -----------
  The maximum value of a PID is 4194303, not 32767

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 965ea09abee3a0c6a03bf367e02ac394e03ed2b2
      https://github.com/acassen/keepalived/commit/965ea09abee3a0c6a03bf367e02ac394e03ed2b2
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-19 (Thu, 19 Oct 2017)

  Changed paths:
    M lib/scheduler.c

  Log Message:
  -----------
  After select() returns don't check all timers of read/write threads

The threads are queued in timer order, so if we reach a timer that
hasn't expired, then all the subsequent timers will also not have
expired.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: f4c8a8519cf11a453c30103f6f42c6e5e7a610c6
      https://github.com/acassen/keepalived/commit/f4c8a8519cf11a453c30103f6f42c6e5e7a610c6
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-20 (Fri, 20 Oct 2017)

  Changed paths:
    M keepalived/check/check_misc.c
    M keepalived/include/check_misc.h
    M keepalived/include/vrrp_track.h
    M keepalived/vrrp/vrrp_data.c
    M keepalived/vrrp/vrrp_scheduler.c
    M lib/notify.h

  Log Message:
  -----------
  Fix handling of termination of vrrp_track and check_misc scripts

There were circumstances where a track script could terminate
normally even if keepalived had or thought it had sent a signal
to the script to terminate it, and in these circumstances keepalived
still treated the script as though it had failed.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: c334efaa09b943fa81a956962acb47f31f8e7e88
      https://github.com/acassen/keepalived/commit/c334efaa09b943fa81a956962acb47f31f8e7e88
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-20 (Fri, 20 Oct 2017)

  Changed paths:
    M keepalived/vrrp/vrrp_data.c

  Log Message:
  -----------
  Print vrrp track script states in keepalived.data

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 40b01f9c5d3e59162abcf9dc46c5b4294f50ecad
      https://github.com/acassen/keepalived/commit/40b01f9c5d3e59162abcf9dc46c5b4294f50ecad
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-20 (Fri, 20 Oct 2017)

  Changed paths:
    M keepalived/check/check_misc.c
    M keepalived/vrrp/vrrp_scheduler.c

  Log Message:
  -----------
  Streamline handling termination of vrrp track and check_misc scripts

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 3ff402c088377183bc17cd5cdd2fb56e56b0550b
      https://github.com/acassen/keepalived/commit/3ff402c088377183bc17cd5cdd2fb56e56b0550b
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-20 (Fri, 20 Oct 2017)

  Changed paths:
    M keepalived/check/check_misc.c

  Log Message:
  -----------
  Ensure at least some delay between running a check_misc script

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 7705619a8c26f6c04407ecbb9e382d35565ad6da
      https://github.com/acassen/keepalived/commit/7705619a8c26f6c04407ecbb9e382d35565ad6da
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-21 (Sat, 21 Oct 2017)

  Changed paths:
    M keepalived/core/main.c

  Log Message:
  -----------
  Add Linux build and runtime versions to -v output

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 918d56895cc1f628ac2661df59cd88ae5f449b30
      https://github.com/acassen/keepalived/commit/918d56895cc1f628ac2661df59cd88ae5f449b30
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-21 (Sat, 21 Oct 2017)

  Changed paths:
    M keepalived/core/main.c

  Log Message:
  -----------
  Log kernel version and build kernel version to log at startup

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 2ccaafa21f46123dcecd5229bfb1e75d562f3da8
      https://github.com/acassen/keepalived/commit/2ccaafa21f46123dcecd5229bfb1e75d562f3da8
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-21 (Sat, 21 Oct 2017)

  Changed paths:
    M keepalived/check/check_http.c
    M lib/bitops.h
    M lib/scheduler.c

  Log Message:
  -----------
  Fix compiling with --enable-debug

This commit also only defines MEM_ERR_DETECT_BIT if mem-check is enabled.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 913fdaa172815df5c45269e46a02152f45d970c7
      https://github.com/acassen/keepalived/commit/913fdaa172815df5c45269e46a02152f45d970c7
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-21 (Sat, 21 Oct 2017)

  Changed paths:
    M keepalived/vrrp/vrrp_daemon.c

  Log Message:
  -----------
  Don't sleep for 1 send when exiting vrrp process if no vrrp instances

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: b553f3676f410ff95405c9f7eaca974aaa3ee0d2
      https://github.com/acassen/keepalived/commit/b553f3676f410ff95405c9f7eaca974aaa3ee0d2
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-21 (Sat, 21 Oct 2017)

  Changed paths:
    M keepalived/check/check_daemon.c
    M keepalived/core/main.c
    M keepalived/include/vrrp_scheduler.h
    M keepalived/vrrp/vrrp_daemon.c
    M keepalived/vrrp/vrrp_scheduler.c
    M lib/scheduler.c
    M lib/scheduler.h

  Log Message:
  -----------
  Streamline and rationalise use of child_finder function

The child_finder function is simplified, and also stop using the
parent process' child_finder function in the checker process.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 2276b8f8a88671c268b8e3fa1b3125c7fdcd339c
      https://github.com/acassen/keepalived/commit/2276b8f8a88671c268b8e3fa1b3125c7fdcd339c
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-21 (Sat, 21 Oct 2017)

  Changed paths:
    M lib/scheduler.c

  Log Message:
  -----------
  Don't request bug report if script terminates due to seg fault

The report_child_status() function would log a message requesting a
bug report if a check_misc script or a vrrp_track script exited due
to a seg fault.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: df9e872a85192a041bd857cfe21331bcdd010cfd
      https://github.com/acassen/keepalived/commit/df9e872a85192a041bd857cfe21331bcdd010cfd
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-21 (Sat, 21 Oct 2017)

  Changed paths:
    M lib/notify.c

  Log Message:
  -----------
  Handle vrrp track and check_misc scripts being killed by signal

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: c0f8c1a69613b2cd72b27eceb3e6aa6fa5041bda
      https://github.com/acassen/keepalived/commit/c0f8c1a69613b2cd72b27eceb3e6aa6fa5041bda
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-21 (Sat, 21 Oct 2017)

  Changed paths:
    M keepalived/check/check_misc.c
    M keepalived/include/check_misc.h
    M keepalived/include/vrrp_track.h
    M keepalived/vrrp/vrrp.c
    M keepalived/vrrp/vrrp_data.c
    M keepalived/vrrp/vrrp_parser.c
    M keepalived/vrrp/vrrp_print.c
    M keepalived/vrrp/vrrp_scheduler.c
    M keepalived/vrrp/vrrp_snmp.c
    M keepalived/vrrp/vrrp_track.c
    M lib/notify.h
    M lib/scheduler.c
    M lib/scheduler.h

  Log Message:
  -----------
  Rationalise reporting of child process exit status

report_child_status() is now only called in the main keepalived
program. The reporting of the exit status of vrrp track scripts
and MISC_CHECK scripts is now handled in the specific code for
those scripts. This means that non 0 exit statuses aren't
repeatedly reported for vrrp track scripts.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: c1763f1044b28586ded552920e51aad9143baab9
      https://github.com/acassen/keepalived/commit/c1763f1044b28586ded552920e51aad9143baab9
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-21 (Sat, 21 Oct 2017)

  Changed paths:
    M ChangeLog
    M configure
    M configure.ac
    M keepalived/include/vrrp_index.h
    M keepalived/vrrp/vrrp_data.c
    M keepalived/vrrp/vrrp_index.c
    M keepalived/vrrp/vrrp_parser.c
    M keepalived/vrrp/vrrp_scheduler.c

  Log Message:
  -----------
  Merge branch 'master' into fixes


  Commit: 5f898da92de803c7b145d1e4727906a707af93df
      https://github.com/acassen/keepalived/commit/5f898da92de803c7b145d1e4727906a707af93df
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-22 (Sun, 22 Oct 2017)

  Changed paths:
    M keepalived/check/check_misc.c

  Log Message:
  -----------
  eally fix reporting of child process exit status

Commit c0f8c1a had a small error for check_misc scripts.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: d8db888e1d99a99a8af8578db1dcae8bc8747f6a
      https://github.com/acassen/keepalived/commit/d8db888e1d99a99a8af8578db1dcae8bc8747f6a
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-22 (Sun, 22 Oct 2017)

  Changed paths:
    M lib/memory.c

  Log Message:
  -----------
  Log a helpful message i using mem-check and too many allocs

keepalived simply being terminated by SIGABRT with no diagnostic
message was unhelpful.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 8ee186989203dc72d7ba61102a2a7ac69a71a689
      https://github.com/acassen/keepalived/commit/8ee186989203dc72d7ba61102a2a7ac69a71a689
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-22 (Sun, 22 Oct 2017)

  Changed paths:
    M keepalived/check/check_daemon.c
    M keepalived/core/main.c
    M keepalived/include/vrrp_scheduler.h
    M keepalived/vrrp/vrrp.c
    M keepalived/vrrp/vrrp_daemon.c
    M keepalived/vrrp/vrrp_scheduler.c
    M lib/scheduler.c
    M lib/scheduler.h

  Log Message:
  -----------
  Rename child_finder() to child_finder_name() etc

The function only finds the name of the child process, and not
the thread for the child process, so rename the function accordingly.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 8759c575b519a7d64c23080507b1eeb3724a3baa
      https://github.com/acassen/keepalived/commit/8759c575b519a7d64c23080507b1eeb3724a3baa
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-23 (Mon, 23 Oct 2017)

  Changed paths:
    M keepalived/check/check_daemon.c
    M keepalived/core/main.c
    M keepalived/include/main.h
    M keepalived/vrrp/vrrp_daemon.c
    M lib/bitops.h
    M lib/logger.c
    M lib/logger.h

  Log Message:
  -----------
  Add log to file and no syslog options

With large configurations the syslog can get flooded and drop output.
This commit adds options to not log to syslog, and also to log all
output to files.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 5e5767938e227a64273f387b9e502fc1444b97b9
      https://github.com/acassen/keepalived/commit/5e5767938e227a64273f387b9e502fc1444b97b9
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-23 (Mon, 23 Oct 2017)

  Changed paths:
    M keepalived/check/check_daemon.c
    M keepalived/check/ipvswrapper.c
    M keepalived/core/daemon.c
    M keepalived/core/main.c
    M keepalived/include/daemon.h
    M keepalived/include/main.h
    M keepalived/vrrp/vrrp_daemon.c
    M lib/logger.c
    M lib/logger.h
    M lib/notify.c
    M lib/signals.c
    M lib/utils.c
    M lib/utils.h

  Log Message:
  -----------
  Add option to only flush log files before forking

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 194363d420bc34f568c7c4546a14507a29583123
      https://github.com/acassen/keepalived/commit/194363d420bc34f568c7c4546a14507a29583123
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-25 (Wed, 25 Oct 2017)

  Changed paths:
    M keepalived/core/keepalived_netlink.c
    M keepalived/include/keepalived_netlink.h
    M keepalived/vrrp/vrrp.c
    M keepalived/vrrp/vrrp_if.c
    M keepalived/vrrp/vrrp_vmac.c

  Log Message:
  -----------
  Don't poll netlink for all interfaces each time add a VMAC

We can poll for the individual interface details which significantly
reduces what we have to process.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: a620f325bc9969a8e91512d4890afc198e8f5d89
      https://github.com/acassen/keepalived/commit/a620f325bc9969a8e91512d4890afc198e8f5d89
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-25 (Wed, 25 Oct 2017)

  Changed paths:
    M keepalived/include/vrrp_if.h
    M keepalived/vrrp/vrrp_if.c
    M keepalived/vrrp/vrrp_print.c

  Log Message:
  -----------
  Print interface details in keepalived.data output

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 5d11992838f4b7be994ac6b5e397ff7019845d37
      https://github.com/acassen/keepalived/commit/5d11992838f4b7be994ac6b5e397ff7019845d37
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-25 (Wed, 25 Oct 2017)

  Changed paths:
    M lib/list.c
    M lib/list.h

  Log Message:
  -----------
  Be consistent with type of size parameter for mlists

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 34d2be150454d4a86996b0cde635ac0cf4095add
      https://github.com/acassen/keepalived/commit/34d2be150454d4a86996b0cde635ac0cf4095add
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-25 (Wed, 25 Oct 2017)

  Changed paths:
    M keepalived/check/check_misc.c
    M keepalived/core/main.c
    M keepalived/vrrp/vrrp_scheduler.c
    M lib/logger.c

  Log Message:
  -----------
  Fix sign conversion warnings

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 9e26d94e52b74247e74341e22df0b8c1fd8cb8e8
      https://github.com/acassen/keepalived/commit/9e26d94e52b74247e74341e22df0b8c1fd8cb8e8
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-25 (Wed, 25 Oct 2017)

  Changed paths:
    M keepalived/check/check_daemon.c
    M keepalived/check/check_misc.c
    M keepalived/vrrp/vrrp_daemon.c
    M keepalived/vrrp/vrrp_scheduler.c
    M lib/scheduler.c
    M lib/scheduler.h

  Log Message:
  -----------
  Add high performace child finder code

The code to find the relevant thread to execute afer a child process
(either a vrrp track script or a misc_check healthchecker) was doing
a linear search for the matching pid, which if there are a large number
of child processes running could become time consuming.

The code now will enable high performance child finding, based on using
mlists hashed by the pid, if there are 32 or more vrrp track scripts or
misc check healthcheckers. The size of the mlist is based on the number
of scripts, with a limit of 256.

This is from code written by Damien Clabaut <[email protected]>

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: fff039f6bfd2f045a36667e630c7b4d90a17d0a4
      https://github.com/acassen/keepalived/commit/fff039f6bfd2f045a36667e630c7b4d90a17d0a4
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-29 (Sun, 29 Oct 2017)

  Changed paths:
    M keepalived/check/check_misc.c
    M keepalived/vrrp/vrrp_scheduler.c
    M lib/scheduler.c
    M lib/scheduler.h

  Log Message:
  -----------
  Improve high performance child termination timeout code

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 4a96f0128619b44c21b1e11216fa20a9de3fef66
      https://github.com/acassen/keepalived/commit/4a96f0128619b44c21b1e11216fa20a9de3fef66
  Author: pqarmitage <[email protected]>
  Date:   2017-10-29 (Sun, 29 Oct 2017)

  Changed paths:
    M keepalived/check/check_daemon.c
    M keepalived/check/check_http.c
    M keepalived/check/check_misc.c
    M keepalived/check/ipvswrapper.c
    M keepalived/core/daemon.c
    M keepalived/core/keepalived_netlink.c
    M keepalived/core/main.c
    M keepalived/include/check_misc.h
    M keepalived/include/daemon.h
    M keepalived/include/keepalived_netlink.h
    M keepalived/include/vrrp_if.h
    M keepalived/include/vrrp_scheduler.h
    M keepalived/include/vrrp_track.h
    M keepalived/vrrp/vrrp.c
    M keepalived/vrrp/vrrp_daemon.c
    M keepalived/vrrp/vrrp_data.c
    M keepalived/vrrp/vrrp_if.c
    M keepalived/vrrp/vrrp_if_config.c
    M keepalived/vrrp/vrrp_parser.c
    M keepalived/vrrp/vrrp_print.c
    M keepalived/vrrp/vrrp_scheduler.c
    M keepalived/vrrp/vrrp_snmp.c
    M keepalived/vrrp/vrrp_track.c
    M keepalived/vrrp/vrrp_vmac.c
    M lib/bitops.h
    M lib/list.c
    M lib/list.h
    M lib/logger.c
    M lib/logger.h
    M lib/memory.c
    M lib/notify.c
    M lib/notify.h
    M lib/scheduler.c
    M lib/scheduler.h
    M lib/signals.c
    M lib/utils.c
    M lib/utils.h

  Log Message:
  -----------
  Merge pull request #682 from pqarmitage/fixes

A variety of updates


Compare: https://github.com/acassen/keepalived/compare/5efb85abebd5...4a96f0128619

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

_______________________________________________
Keepalived-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/keepalived-devel