[acassen/keepalived] e3dc27: Merge pull request #684 from pqarmitage/fixes

pqarmitage <[email protected]> Mon, 30 Oct 2017 12:07:55 -0700
Newsgroups gmane.linux.keepalived.devel
Message-ID <59f7788b562e2_41d63fc8537dfc342098a1@hookshot-fe1-cp1-prd.iad.github.net.mail>
  Branch: refs/heads/beta
  Home:   https://github.com/acassen/keepalived
  Commit: e3dc270e7a7b079b4a30e832a63bd44689ae0f88
      https://github.com/acassen/keepalived/commit/e3dc270e7a7b079b4a30e832a63bd44689ae0f88
  Author: pqarmitage <[email protected]>
  Date:   2017-10-29 (Sun, 29 Oct 2017)

  Changed paths:
    M lib/scheduler.c

  Log Message:
  -----------
  Merge pull request #684 from pqarmitage/fixes

Fix high performance child finder cleanup code


  Commit: acfb9a028a54334954a0ca4d923ac1361b7980c0
      https://github.com/acassen/keepalived/commit/acfb9a028a54334954a0ca4d923ac1361b7980c0
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-30 (Mon, 30 Oct 2017)

  Changed paths:
    M lib/notify.c

  Log Message:
  -----------
  Preserve filename in script path name resolution

Some executables change their behaviour depending on the name by
which they are invoked (e.g. /usr/sbin/pidof when it is a link to
/usr/sbin/killall5). Using realpath() changes the file name part
if it is a symbolic link. This commit resolves all symbolic links
to directories, but leaves the file name part unaltered. It then
checks the security of both the path to the link and the path to
the real file.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 99906be0a91a92a0380b1d26f6a3516e34d019e4
      https://github.com/acassen/keepalived/commit/99906be0a91a92a0380b1d26f6a3516e34d019e4
  Author: pqarmitage <[email protected]>
  Date:   2017-10-30 (Mon, 30 Oct 2017)

  Changed paths:
    M lib/notify.c

  Log Message:
  -----------
  Merge pull request #687 from pqarmitage/fixes

Preserve filename in script path name resolution


  Commit: 9984929a3e566af4b704991a668d53b43fc4d732
      https://github.com/acassen/keepalived/commit/9984929a3e566af4b704991a668d53b43fc4d732
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-30 (Mon, 30 Oct 2017)

  Changed paths:
    M lib/notify.c

  Log Message:
  -----------
  Remove debugging message left in in commit 99906be

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 37904cf868545a96c32a341124e21cbb10a21f16
      https://github.com/acassen/keepalived/commit/37904cf868545a96c32a341124e21cbb10a21f16
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-30 (Mon, 30 Oct 2017)

  Changed paths:
    M lib/notify.c

  Log Message:
  -----------
  Merge branch 'fixes' into beta

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 69e5b5aaad7a67ce8dc60a5edbab4d45f896363a
      https://github.com/acassen/keepalived/commit/69e5b5aaad7a67ce8dc60a5edbab4d45f896363a
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-30 (Mon, 30 Oct 2017)

  Changed paths:
    M lib/notify.c

  Log Message:
  -----------
  Handle scripts names that are symbolic links properly

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: d614f18b24f13db47b7e1d0baf9ec3c5a656bc72
      https://github.com/acassen/keepalived/commit/d614f18b24f13db47b7e1d0baf9ec3c5a656bc72
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-30 (Mon, 30 Oct 2017)

  Changed paths:
    M lib/notify.c

  Log Message:
  -----------
  Merge branch 'fixes' into beta


  Commit: 18e79f813965875739d6cc6a499ffdb387c7ca9a
      https://github.com/acassen/keepalived/commit/18e79f813965875739d6cc6a499ffdb387c7ca9a
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-30 (Mon, 30 Oct 2017)

  Changed paths:
    M lib/notify.c

  Log Message:
  -----------
  Use fstatat() rather than stat() for checking script security

If we use fstatat() we can discover if a file is a symbolic
link and treat it accordingly.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 785ed1b54722346253f8f5d6f1167f5ade68f50f
      https://github.com/acassen/keepalived/commit/785ed1b54722346253f8f5d6f1167f5ade68f50f
  Author: Quentin Armitage <[email protected]>
  Date:   2017-10-30 (Mon, 30 Oct 2017)

  Changed paths:
    M lib/notify.c

  Log Message:
  -----------
  Merge branch 'fixes' into beta


  Commit: 8176a7c667c5a388e5b3d479d693173c4b5f5f6d
      https://github.com/acassen/keepalived/commit/8176a7c667c5a388e5b3d479d693173c4b5f5f6d
  Author: pqarmitage <[email protected]>
  Date:   2017-10-30 (Mon, 30 Oct 2017)

  Changed paths:
    M lib/notify.c

  Log Message:
  -----------
  Merge pull request #689 from pqarmitage/beta

More improvements to checking script security re symbolic links


Compare: https://github.com/acassen/keepalived/compare/96261c8ad4c1...8176a7c667c5

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

_______________________________________________
Keepalived-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/keepalived-devel