[acassen/keepalived] 2c6134: Fix signed/unsigned comparison

pqarmitage <[email protected]> Mon, 01 Jan 2018 01:38:11 -0800
Newsgroups gmane.linux.keepalived.devel
Message-ID <5a4a0183e6105_67932aca384a1c0885577@hookshot-fe-7191cb1.cp1-iad.github.net.mail> 
  Branch: refs/heads/beta
  Home:   https://github.com/acassen/keepalived
  Commit: 2c6134a246acc42dca80c903ea9ad0f1585ce23c
      https://github.com/acassen/keepalived/commit/2c6134a246acc42dca80c903ea9ad0f1585ce23c
  Author: Quentin Armitage <[email protected]>
  Date:   2017-12-31 (Sun, 31 Dec 2017)

  Changed paths:
    M keepalived/check/ipwrapper.c

  Log Message:
  -----------
  Fix signed/unsigned comparison

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: c9d95cdbefc6c3036984ae21854659427d9c529c
      https://github.com/acassen/keepalived/commit/c9d95cdbefc6c3036984ae21854659427d9c529c
  Author: Quentin Armitage <[email protected]>
  Date:   2017-12-31 (Sun, 31 Dec 2017)

  Changed paths:
    M keepalived/bfd/bfd_parser.c
    M keepalived/bfd/bfd_scheduler.c
    M keepalived/include/bfd.h

  Log Message:
  -----------
  Allow BFD parameters to be any legal value

This commit changes the ranges of the configurable BFD parameters
to be anything supported by the protocol, subject to being configurable
in milli-seconds, whereas previously the limits were artifically
constrained.

If any values configured are outside the previous constraints, then a
warning is logged that the configured values may not be sensible.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 8316ff96ce7f607bd74891088ee87409467dc5fa
      https://github.com/acassen/keepalived/commit/8316ff96ce7f607bd74891088ee87409467dc5fa
  Author: Quentin Armitage <[email protected]>
  Date:   2017-12-31 (Sun, 31 Dec 2017)

  Changed paths:
    M keepalived/bfd/bfd_daemon.c
    M keepalived/core/main.c
    M keepalived/vrrp/vrrp_daemon.c
    M keepalived/vrrp/vrrp_dbus.c
    M lib/signals.c
    M lib/utils.c
    M lib/utils.h

  Log Message:
  -----------
  Close unused ends of BFD pipe, and streamline pipe opening code

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: f4d5448b055932baaa78122f71fee28ee2df8aa2
      https://github.com/acassen/keepalived/commit/f4d5448b055932baaa78122f71fee28ee2df8aa2
  Author: Quentin Armitage <[email protected]>
  Date:   2017-12-31 (Sun, 31 Dec 2017)

  Changed paths:
    M doc/keepalived.conf.SYNOPSIS
    M doc/man/man5/keepalived.conf.5
    M keepalived/bfd/bfd_daemon.c
    M keepalived/core/main.c

  Log Message:
  -----------
  Add short desciprtion of BFD to man page

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 4d461bad0e6e418803e637ac2d30aa4aeddf1f44
      https://github.com/acassen/keepalived/commit/4d461bad0e6e418803e637ac2d30aa4aeddf1f44
  Author: Quentin Armitage <[email protected]>
  Date:   2017-12-31 (Sun, 31 Dec 2017)

  Changed paths:
    M keepalived/bfd/bfd_daemon.c
    M keepalived/bfd/bfd_event.c
    M keepalived/bfd/bfd_parser.c
    M keepalived/check/check_daemon.c
    M keepalived/check/check_parser.c
    M keepalived/core/global_parser.c
    M keepalived/core/main.c
    M keepalived/core/pidfile.c
    M keepalived/include/main.h
    M keepalived/vrrp/vrrp_daemon.c
    M keepalived/vrrp/vrrp_parser.c
    M lib/parser.c

  Log Message:
  -----------
  Don't run a child process if it has no configuration

For example, if there is no virtual server configuration, there is
no point in running the checker child process.

This can be overridden by specifying --all option.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: eacec9f7588b64a12ff77c0b484821d2fc87a52c
      https://github.com/acassen/keepalived/commit/eacec9f7588b64a12ff77c0b484821d2fc87a52c
  Author: Quentin Armitage <[email protected]>
  Date:   2017-12-31 (Sun, 31 Dec 2017)

  Changed paths:
    M keepalived/core/main.c

  Log Message:
  -----------
  Improve and fix use of getopt_long()

We musn't use a long option val of 1, since getopt_long() can return
that value.

getopt_long() also returns longindex == 0 when there is no matching
long option, and there needs to be careful checking if there is an
error to work out whether a long or short option was used, which is
needed for meaningful error messages.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 36a6735865c291436314d34f4f6081e90e084de3
      https://github.com/acassen/keepalived/commit/36a6735865c291436314d34f4f6081e90e084de3
  Author: Quentin Armitage <[email protected]>
  Date:   2018-01-01 (Mon, 01 Jan 2018)

  Changed paths:
    M keepalived/core/main.c

  Log Message:
  -----------
  Fix commit eacec9f7 - Improve and fix use of getopt_long()

It seems some compilations would cause a segfault, and others wouldn't,
although the code was certainly wrong.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 3a78a13928ea5c4493e2cd154c1e2d4fd1b9b7e0
      https://github.com/acassen/keepalived/commit/3a78a13928ea5c4493e2cd154c1e2d4fd1b9b7e0
  Author: Quentin Armitage <[email protected]>
  Date:   2018-01-01 (Mon, 01 Jan 2018)

  Changed paths:
    M keepalived/core/main.c

  Log Message:
  -----------
  Merge branch 'fixes' into beta


  Commit: f06c204975775d17ef9e39290da72b2ede12798e
      https://github.com/acassen/keepalived/commit/f06c204975775d17ef9e39290da72b2ede12798e
  Author: Quentin Armitage <[email protected]>
  Date:   2018-01-01 (Mon, 01 Jan 2018)

  Changed paths:
    M keepalived/check/check_parser.c
    M keepalived/core/main.c

  Log Message:
  -----------
  Fix compile problem found by Travis-CI

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 1f46d7206c6aa6073480eaacd0e700c2e376e41a
      https://github.com/acassen/keepalived/commit/1f46d7206c6aa6073480eaacd0e700c2e376e41a
  Author: pqarmitage <[email protected]>
  Date:   2018-01-01 (Mon, 01 Jan 2018)

  Changed paths:
    M doc/keepalived.conf.SYNOPSIS
    M doc/man/man5/keepalived.conf.5
    M keepalived/bfd/bfd_daemon.c
    M keepalived/bfd/bfd_event.c
    M keepalived/bfd/bfd_parser.c
    M keepalived/bfd/bfd_scheduler.c
    M keepalived/check/check_daemon.c
    M keepalived/check/check_parser.c
    M keepalived/check/ipwrapper.c
    M keepalived/core/global_parser.c
    M keepalived/core/main.c
    M keepalived/core/pidfile.c
    M keepalived/include/bfd.h
    M keepalived/include/main.h
    M keepalived/vrrp/vrrp_daemon.c
    M keepalived/vrrp/vrrp_dbus.c
    M keepalived/vrrp/vrrp_parser.c
    M lib/parser.c
    M lib/signals.c
    M lib/utils.c
    M lib/utils.h

  Log Message:
  -----------
  Merge pull request #734 from pqarmitage/beta

Some BFD tidying up, and improved handling of getopt_long()


Compare: https://github.com/acassen/keepalived/compare/292d55012e1c...1f46d7206c6a

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

_______________________________________________
Keepalived-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/keepalived-devel