[acassen/keepalived] dbdeea: Use -isystem rather than -I for path to kernel hea...

Quentin Armitage <[email protected]> Thu, 23 May 2019 05:22:41 -0700
Newsgroups gmane.linux.keepalived.devel
Message-ID <acassen/keepalived/push/refs/heads/master/[email protected]>
  Branch: refs/heads/master
  Home:   https://github.com/acassen/keepalived
  Commit: dbdeeaded297a152f29de62ae161215669bb9118
      https://github.com/acassen/keepalived/commit/dbdeeaded297a152f29de62ae161215669bb9118
  Author: Quentin Armitage <[email protected]>
  Date:   2019-05-22 (Wed, 22 May 2019)

  Changed paths:
    M configure.ac

  Log Message:
  -----------
  Use -isystem rather than -I for path to kernel headers

Using -isystem rather than -I allows the dispensation for some warnings
to system headers to apply to the kernel header tree we are specifying.
This stops some warnings that would not occur with kernel headers under
/usr/include but that were being generated when -I was used (it
nevertheless has helped identify two bugs).

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 66e12fe45012f9629e64a6cea981838b40c4b65c
      https://github.com/acassen/keepalived/commit/66e12fe45012f9629e64a6cea981838b40c4b65c
  Author: Quentin Armitage <[email protected]>
  Date:   2019-05-22 (Wed, 22 May 2019)

  Changed paths:
    M keepalived/include/vrrp_nftables.h

  Log Message:
  -----------
  Ensure check system headers for definition of NFT_TABLE_MAXNAMELEN

Prior to Linux 4.1 NFT_TABLE_MAXNAMELEN was not defined, but we must
include linux/netfilter/nf_tables.h before checking whether it is
defined or not!

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 7b4d393e75592b84383b0782033da942f34baa6b
      https://github.com/acassen/keepalived/commit/7b4d393e75592b84383b0782033da942f34baa6b
  Author: Quentin Armitage <[email protected]>
  Date:   2019-05-22 (Wed, 22 May 2019)

  Changed paths:
    M configure.ac

  Log Message:
  -----------
  Improved configure testing for <linux/netfilter/nf_tables.h>

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: a0b87106673d60b113439c9e261088099fb51895
      https://github.com/acassen/keepalived/commit/a0b87106673d60b113439c9e261088099fb51895
  Author: Quentin Armitage <[email protected]>
  Date:   2019-05-22 (Wed, 22 May 2019)

  Changed paths:
    M configure.ac
    M genhash/http.c
    M genhash/include/main.h
    M genhash/main.c
    M keepalived/check/check_misc.c
    M keepalived/check/check_parser.c
    M keepalived/check/ipvswrapper.c
    M keepalived/check/ipwrapper.c
    M keepalived/core/keepalived_netlink.c
    M keepalived/vrrp/vrrp.c
    M keepalived/vrrp/vrrp_data.c
    M keepalived/vrrp/vrrp_dbus.c
    M keepalived/vrrp/vrrp_iptables_lib.c
    M keepalived/vrrp/vrrp_json.c
    M keepalived/vrrp/vrrp_nftables.c
    M keepalived/vrrp/vrrp_notify.c
    M keepalived/vrrp/vrrp_scheduler.c
    M keepalived/vrrp/vrrp_snmp.c
    M lib/scheduler.c
    M lib/utils.c

  Log Message:
  -----------
  Add warning -Wwrite-strings and resolve new warnings

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: bec382e26af83c89a78cca0d62646adf46cc0139
      https://github.com/acassen/keepalived/commit/bec382e26af83c89a78cca0d62646adf46cc0139
  Author: Quentin Armitage <[email protected]>
  Date:   2019-05-22 (Wed, 22 May 2019)

  Changed paths:
    M configure.ac
    M keepalived/core/global_data.c
    M keepalived/vrrp/vrrp.c
    M keepalived/vrrp/vrrp_daemon.c
    M keepalived/vrrp/vrrp_data.c
    M keepalived/vrrp/vrrp_ip_rule_route_parser.c
    M keepalived/vrrp/vrrp_iproute.c
    M keepalived/vrrp/vrrp_json.c
    M lib/timer.h

  Log Message:
  -----------
  Add -Wdouble-promotion and resolve new warnings

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: c011e0d87dc52270ee28b4085d857acd9db6747d
      https://github.com/acassen/keepalived/commit/c011e0d87dc52270ee28b4085d857acd9db6747d
  Author: Quentin Armitage <[email protected]>
  Date:   2019-05-23 (Thu, 23 May 2019)

  Changed paths:
    M configure.ac
    M keepalived/bfd/bfd.c
    M keepalived/bfd/bfd_daemon.c
    M keepalived/bfd/bfd_data.c
    M keepalived/bfd/bfd_parser.c
    M keepalived/bfd/bfd_scheduler.c
    M keepalived/check/check_api.c
    M keepalived/check/check_bfd.c
    M keepalived/check/check_data.c
    M keepalived/check/check_dns.c
    M keepalived/check/check_http.c
    M keepalived/check/check_misc.c
    M keepalived/check/check_tcp.c
    M keepalived/check/ipwrapper.c
    M keepalived/core/global_data.c
    M keepalived/core/global_parser.c
    M keepalived/core/keepalived_netlink.c
    M keepalived/core/layer4.c
    M keepalived/core/track_process.c
    M keepalived/vrrp/vrrp.c
    M keepalived/vrrp/vrrp_data.c
    M keepalived/vrrp/vrrp_if.c
    M keepalived/vrrp/vrrp_if_config.c
    M keepalived/vrrp/vrrp_iproute.c
    M keepalived/vrrp/vrrp_iprule.c
    M keepalived/vrrp/vrrp_parser.c
    M keepalived/vrrp/vrrp_print.c
    M keepalived/vrrp/vrrp_scheduler.c
    M keepalived/vrrp/vrrp_snmp.c
    M keepalived/vrrp/vrrp_static_track.c
    M lib/assert.c
    M lib/memory.c
    M lib/notify.c
    M lib/parser.c
    M lib/scheduler.c
    M lib/timer.c
    M lib/utils.c

  Log Message:
  -----------
  Add -Wformat-signedness and resolve new warnings

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 63a7b5bc267628d7a6592e1a20bbceec4b9372c7
      https://github.com/acassen/keepalived/commit/63a7b5bc267628d7a6592e1a20bbceec4b9372c7
  Author: Quentin Armitage <[email protected]>
  Date:   2019-05-23 (Thu, 23 May 2019)

  Changed paths:
    M keepalived/check/ipwrapper.c

  Log Message:
  -----------
  Fix building on Ubuntu 16.04 with --disable-vrrp

The addition of including <inttypes.h> was needed on Ubuntu 16.04,
whereas it wasn't necessary on Fedora or Debian.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: f60beae6137e2fe3a88d7907d86bf8595f3a3b74
      https://github.com/acassen/keepalived/commit/f60beae6137e2fe3a88d7907d86bf8595f3a3b74
  Author: Quentin Armitage <[email protected]>
  Date:   2019-05-23 (Thu, 23 May 2019)

  Changed paths:
    M keepalived/check/check_bfd.c
    M keepalived/core/keepalived_netlink.c
    M keepalived/core/track_process.c
    M keepalived/vrrp/vrrp.c
    M keepalived/vrrp/vrrp_if.c
    M keepalived/vrrp/vrrp_scheduler.c
    M keepalived/vrrp/vrrp_snmp.c

  Log Message:
  -----------
  Explicitly include <inttypes.h> where print format names are used

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 27c22be94898b7bd5fdef6ef680906331ff01e8b
      https://github.com/acassen/keepalived/commit/27c22be94898b7bd5fdef6ef680906331ff01e8b
  Author: Quentin Armitage <[email protected]>
  Date:   2019-05-23 (Thu, 23 May 2019)

  Changed paths:
    M configure.ac
    M keepalived/core/smtp.c
    M keepalived/core/track_process.c
    M lib/scheduler.c

  Log Message:
  -----------
  Add more -Wformat-* options and resolve new warnings

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: a6cfb0ac483dd9c500a88907f5c2285705fa86b5
      https://github.com/acassen/keepalived/commit/a6cfb0ac483dd9c500a88907f5c2285705fa86b5
  Author: Quentin Armitage <[email protected]>
  Date:   2019-05-23 (Thu, 23 May 2019)

  Changed paths:
    M configure.ac

  Log Message:
  -----------
  Add -Wframe-larger-than=5120

The largest frame is just under 4200 bytes (which may be more than we
want anyway), but adding this warning will at least tell us if a stupidly
large frame is created in the future.

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: d0acc6529209306dc6c3e10256d812ebb4c0f1cc
      https://github.com/acassen/keepalived/commit/d0acc6529209306dc6c3e10256d812ebb4c0f1cc
  Author: Quentin Armitage <[email protected]>
  Date:   2019-05-23 (Thu, 23 May 2019)

  Changed paths:
    M configure.ac

  Log Message:
  -----------
  Fix spelling of -Wmissing-field-initializers

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 0f582a63a243215a40f08c78f6e1f1b149c86e53
      https://github.com/acassen/keepalived/commit/0f582a63a243215a40f08c78f6e1f1b149c86e53
  Author: Quentin Armitage <[email protected]>
  Date:   2019-05-23 (Thu, 23 May 2019)

  Changed paths:
    M configure.ac

  Log Message:
  -----------
  Fix definition of PRI_rlim_t generated by configure on 32 bit systems

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: ed1ce450aff0bc143878dc6a81d6a376e81fc480
      https://github.com/acassen/keepalived/commit/ed1ce450aff0bc143878dc6a81d6a376e81fc480
  Author: Quentin Armitage <[email protected]>
  Date:   2019-05-23 (Thu, 23 May 2019)

  Changed paths:
    M keepalived/bfd/bfd_scheduler.c
    M keepalived/include/bfd.h

  Log Message:
  -----------
  Rseolve warning re >=0 comparison for unsigned value

Signed-off-by: Quentin Armitage <[email protected]>


  Commit: 2ac461f11e0361311c4b5676e22c54295c334a62
      https://github.com/acassen/keepalived/commit/2ac461f11e0361311c4b5676e22c54295c334a62
  Author: Quentin Armitage <[email protected]>
  Date:   2019-05-23 (Thu, 23 May 2019)

  Changed paths:
    M configure.ac
    M genhash/http.c
    M genhash/include/main.h
    M genhash/main.c
    M keepalived/bfd/bfd.c
    M keepalived/bfd/bfd_daemon.c
    M keepalived/bfd/bfd_data.c
    M keepalived/bfd/bfd_parser.c
    M keepalived/bfd/bfd_scheduler.c
    M keepalived/check/check_api.c
    M keepalived/check/check_bfd.c
    M keepalived/check/check_data.c
    M keepalived/check/check_dns.c
    M keepalived/check/check_http.c
    M keepalived/check/check_misc.c
    M keepalived/check/check_parser.c
    M keepalived/check/check_tcp.c
    M keepalived/check/ipvswrapper.c
    M keepalived/check/ipwrapper.c
    M keepalived/core/global_data.c
    M keepalived/core/global_parser.c
    M keepalived/core/keepalived_netlink.c
    M keepalived/core/layer4.c
    M keepalived/core/smtp.c
    M keepalived/core/track_process.c
    M keepalived/include/bfd.h
    M keepalived/include/vrrp_nftables.h
    M keepalived/vrrp/vrrp.c
    M keepalived/vrrp/vrrp_daemon.c
    M keepalived/vrrp/vrrp_data.c
    M keepalived/vrrp/vrrp_dbus.c
    M keepalived/vrrp/vrrp_if.c
    M keepalived/vrrp/vrrp_if_config.c
    M keepalived/vrrp/vrrp_ip_rule_route_parser.c
    M keepalived/vrrp/vrrp_iproute.c
    M keepalived/vrrp/vrrp_iprule.c
    M keepalived/vrrp/vrrp_iptables_lib.c
    M keepalived/vrrp/vrrp_json.c
    M keepalived/vrrp/vrrp_nftables.c
    M keepalived/vrrp/vrrp_notify.c
    M keepalived/vrrp/vrrp_parser.c
    M keepalived/vrrp/vrrp_print.c
    M keepalived/vrrp/vrrp_scheduler.c
    M keepalived/vrrp/vrrp_snmp.c
    M keepalived/vrrp/vrrp_static_track.c
    M lib/assert.c
    M lib/memory.c
    M lib/notify.c
    M lib/parser.c
    M lib/scheduler.c
    M lib/timer.c
    M lib/timer.h
    M lib/utils.c

  Log Message:
  -----------
  Merge pull request #1282 from pqarmitage/updates

Add further compiler warnings options and resolve new warnings


Compare: https://github.com/acassen/keepalived/compare/2a9d61d8b53f...2ac461f11e03