Re: [PATCH v1 11/11] fs: aio: add explicit check for large folio in aio_migrate_folio()

On 2024/3/21 11:35, Matthew Wilcox wrote:
> On Thu, Mar 21, 2024 at 11:27:47AM +0800, Kefeng Wang wrote:
>> Since large folio copy could spend lots of time and it is involved with
>> a cond_resched(), the aio couldn't support migrate large folio as it takes
>> a spin lock when folio copy, add explicit check for large folio and return
>> err directly.
> 
> This is unnecessary.  aio only allocates order-0 folios (it uses
> find_or_create_page() to do it).

Yes, only order-0 now, I will drop it.

> 
> If you want to take on converting aio to use folios instead of pages,
> that'd be a worthwhile project.

OK, will try, thanks for your review.
>