Re: [PATCH v6 02/10] block: Call blkdev_dio_unaligned() from blkdev_direct_IO()
John Garry <[email protected]>
| Newsgroups | gmane.linux.kernel.aio.general,gmane.linux.block,gmane.linux.kernel,gmane.linux.file-systems,gmane.linux.scsi,gmane.comp.file-systems.btrfs,gmane.linux.kernel.io-uring |
|---|---|
| Organization | Oracle Corporation |
| Message-ID | <[email protected]> |
On 10/04/2024 23:53, Luis Chamberlain wrote: > On Tue, Mar 26, 2024 at 01:38:05PM +0000, John Garry wrote: >> blkdev_dio_unaligned() is called from __blkdev_direct_IO(), >> __blkdev_direct_IO_simple(), and __blkdev_direct_IO_async(), and all these >> are only called from blkdev_direct_IO(). >> >> Move the blkdev_dio_unaligned() call to the common callsite, >> blkdev_direct_IO(). >> >> Pass those functions the bdev pointer from blkdev_direct_IO() as it is non- >> trivial to calculate. >> >> Reviewed-by: Keith Busch<[email protected]> >> Reviewed-by: Christoph Hellwig<[email protected]> >> Signed-off-by: John Garry<[email protected]> > Reviewed-by: Luis Chamberlain<[email protected]> > cheers > I think this patch should just be sent separately already and not part > of this series. That just creates a merge dependency, since I have later changes which depend on this. I suppose that since we're nearly at rc4, I could do that. John -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to [email protected]. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: <a href=mailto:"[email protected]">[email protected]</a>