Re: [PATCH linux] arch: Wire up io_pgetevents_time64 compat entry point on i386

Guillem Jover <[email protected]>
Newsgroups gmane.linux.kernel.aio.general
Message-ID <[email protected]>
Hi!

On Mon, 2024-06-03 at 22:23:15 +0000, Guillem Jover wrote:
> From: Guillem Jover <[email protected]>
> 
> The io_pgetevents_time64 syscall, at least on x86 64-bit kernels running
> 32-bit userland, misbehaves when passing a sigmask by always returning
> -EINVAL. This works on 32-bit kernels.
> 
> This was seen when adding time64 support for 32-bit architectures to
> libaio, where its test suite started to fail at least on x86 32-bit
> userland runnong on a 64-bit kernel.
           ^
Hmm, just noticed the typo after sending the patch.

> It seems like all other 32-bit architectures would need the same
> treatment,

Actually, I guess only 32-bit ports that have a companion 64-bit one
that can run the 32-bit userland.

> but it is not clear why that was not done when these syscalls
> got introduced, and as that has not been tested they are left out.
> 
> Signed-off-by: Guillem Jover <[email protected]>
> ---
>  arch/x86/entry/syscalls/syscall_32.tbl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/entry/syscalls/syscall_32.tbl b/arch/x86/entry/syscalls/syscall_32.tbl
> index 5f8591ce7f25..fccb825ca2ca 100644
> --- a/arch/x86/entry/syscalls/syscall_32.tbl
> +++ b/arch/x86/entry/syscalls/syscall_32.tbl
> @@ -420,7 +420,7 @@
>  412	i386	utimensat_time64	sys_utimensat
>  413	i386	pselect6_time64		sys_pselect6			compat_sys_pselect6_time64
>  414	i386	ppoll_time64		sys_ppoll			compat_sys_ppoll_time64
> -416	i386	io_pgetevents_time64	sys_io_pgetevents
> +416	i386	io_pgetevents_time64	sys_io_pgetevents		compat_sys_io_pgetevents_time64
>  417	i386	recvmmsg_time64		sys_recvmmsg			compat_sys_recvmmsg_time64
>  418	i386	mq_timedsend_time64	sys_mq_timedsend
>  419	i386	mq_timedreceive_time64	sys_mq_timedreceive
> -- 
> 2.45.1


--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to [email protected].  For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"[email protected]">[email protected]</a>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.